Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constant reference in ConsistentProbabilityTraceState #1450

Merged
merged 3 commits into from
May 23, 2023
Merged

Fix constant reference in ConsistentProbabilityTraceState #1450

merged 3 commits into from
May 23, 2023

Conversation

plantfansam
Copy link
Contributor

.DEFAULT -> ::DEFAULT

@plantfansam plantfansam changed the title Fix constant reference in cps sampler Fix constant reference in ConsistentProbabilityTraceState May 22, 2023
ericmustin
ericmustin approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@plantfansam
Copy link
Contributor Author

Specs are failing for unrelated reason:

In Gemfile:
rubocop was resolved to 0.73.0, which depends on
jaro_winkler

I think potentially jaro_winkler hasn't released the JRuby-compatible version of 1.5.5):

image

rubocop no longer depends on jaro-winkler so we can potentially just upgrade rubocop, but that's actually some work #1321.

@ericmustin
Copy link
Contributor

I think it's fine to merge , can ignore test suite imo? Wdyt?

@plantfansam
Copy link
Contributor Author

plantfansam commented May 22, 2023 •
edited
Loading

I think it's fine to merge , can ignore test suite imo? Wdyt?

test passage is not a blocker for me, but I am working on fixing specs on another branch

@plantfansam
Copy link
Contributor Author

Working on rubocop upgrades here #1452

@fbogsany fbogsany merged commit 1ad4a21 into main May 23, 2023
@plantfansam plantfansam deleted the fix-constant branch May 23, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbogsany fbogsany fbogsany approved these changes

@ericmustin ericmustin ericmustin approved these changes

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plantfansam @ericmustin @fbogsany