feat: instrument graphql #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbogsany
reviewed
Dec 23, 2020
instrumentation/graphql/lib/opentelemetry/instrumentation/graphql/tracers/graphql_tracer.rb
Outdated
Show resolved
Hide resolved
fbogsany
reviewed
Dec 23, 2020
instrumentation/graphql/lib/opentelemetry/instrumentation/graphql/tracers/graphql_tracer.rb
Outdated
Show resolved
Hide resolved
fbogsany
reviewed
Dec 23, 2020
instrumentation/graphql/lib/opentelemetry/instrumentation/graphql/tracers/graphql_tracer.rb
Outdated
Show resolved
Hide resolved
robertlaurin
force-pushed
the
instrument-graphql
branch
from
3acc491
to
c3dfe2c
Compare
robertlaurin
requested review from
dazuma,
ericmustin and
mwear
as code owners
robertlaurin
commented
Dec 23, 2020
Comment on lines
+44
to
+45
| SomeOtherGraphQLAppSchema.remove_instance_variable(:@graphql_definition) if SomeOtherGraphQLAppSchema.instance_variable_defined?(:@graphql_definition) | ||
| SomeGraphQLAppSchema.remove_instance_variable(:@graphql_definition) if SomeGraphQLAppSchema.instance_variable_defined?(:@graphql_definition) |
There was a problem hiding this comment.
There was some fairly tricky state leaking between tests, particularly for 1.9.x version of GraphQL. This is required to prevent duplicate tracers executing, as well as running the tests that would not otherwise have a tracer added. This came up when adding the config options for schemas.
fbogsany
reviewed
Dec 24, 2020
fbogsany
reviewed
Dec 24, 2020
instrumentation/graphql/lib/opentelemetry/instrumentation/graphql/instrumentation.rb
Outdated
Show resolved
Hide resolved
fbogsany
approved these changes
Dec 24, 2020
ericmustin
approved these changes
Dec 24, 2020
instrumentation/graphql/lib/opentelemetry/instrumentation/graphql/tracers/graphql_tracer.rb
Show resolved
Hide resolved
instrumentation/graphql/README.md
Outdated
Comment on lines
39
to
43
| enable_platform_field: true, | ||
| # enable_platform_authorized maps to the authorized and authorized_lazy keys | ||
| enable_platform_authorized: true, | ||
| # enable_platform_resolve_type maps to the resolve_type and resolve_type_lazy keys | ||
| enable_platform_resolve_type: true |
There was a problem hiding this comment.
very small nit but maybe we should leave these commented out so we avoid ppl copy/pasting this snippet in and enabling stuff that, for the most part, we want disabled
There was a problem hiding this comment.
I see what you mean, I wanted to demonstrate how they could turn it on but I guess I can just as easily do that by provided a false value instead. I'll give it an update.
fix: update options description comment Co-authored-by: Francis Bogsanyi <francis.bogsanyi@shopify.com>
robertlaurin
force-pushed
the
instrument-graphql
branch
from
f62e194
to
d8fab42
Compare
fbogsany
approved these changes
Dec 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of the work done here #410