Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delta aggregation metric reuse #1434

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

jtescher
Copy link
Member

@jtescher jtescher commented Dec 9, 2023

Fixes #1432

Changes

This simplifies data aggregation by clearing data points instead of the current more complicated re-use strategy.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (bd3ba65) 58.3% compared to head (0fb099b) 60.4%.
Report is 1 commits behind head on main.

❗ Current head 0fb099b differs from pull request most recent head d2b9a9f. Consider uploading reports for the commit d2b9a9f to get more accurate results

Files Patch % Lines
...-sdk/src/metrics/internal/exponential_histogram.rs 92.5% 4 Missing ⚠️
opentelemetry-sdk/src/metrics/internal/sum.rs 93.1% 3 Missing ⚠️
...entelemetry-sdk/src/metrics/internal/last_value.rs 81.8% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1434     +/-   ##
=======================================
+ Coverage   58.3%   60.4%   +2.0%     
=======================================
  Files        146     146             
  Lines      18827   18807     -20     
=======================================
+ Hits       10994   11360    +366     
+ Misses      7833    7447    -386     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtescher jtescher marked this pull request as ready for review December 9, 2023 20:00
@jtescher jtescher requested a review from a team as a code owner December 9, 2023 20:00
@cijothomas cijothomas merged commit 7d0b80e into open-telemetry:main Dec 13, 2023
13 checks passed
@hdost
Copy link
Contributor

hdost commented Dec 13, 2023

Thank you for the fix!

@jtescher jtescher deleted the simplify-aggregation branch January 4, 2024 15:58
jtescher added a commit that referenced this pull request Jan 4, 2024
guswynn pushed a commit to MaterializeInc/opentelemetry-rust that referenced this pull request Jan 24, 2024
guswynn pushed a commit to MaterializeInc/opentelemetry-rust that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Serious metric corruption
4 participants