Fix max_scale validation of exponential histogram configuration #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inahga
force-pushed
the
inahga/fix-aggregation-validation
branch
from
fa1829e
to
1b5f419
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1452 +/- ##
=======================================
+ Coverage 60.4% 60.6% +0.2%
=======================================
Files 146 146
Lines 18991 19066 +75
=======================================
+ Hits 11483 11573 +90
+ Misses 7508 7493 -15 ☔ View full report in Codecov by Sentry. |
jtescher
approved these changes
Dec 22, 2023
jtescher
added a commit
that referenced
this pull request
Jan 4, 2024
guswynn
pushed a commit
to MaterializeInc/opentelemetry-rust
that referenced
this pull request
Jan 24, 2024
…-telemetry#1452) `metrics::Aggregation::validate()` has a bug that limits `max_scale` of a `Base2ExponentialHistogram` to the interval `[10, 20]` instead of the expected `[-10, 20]`.
guswynn
pushed a commit
to MaterializeInc/opentelemetry-rust
that referenced
this pull request
Jan 24, 2024
Backport open-telemetry#1434 and open-telemetry#1452 to v0.21.x.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metrics::Aggregation::validate()has a bug that limitsmax_scaleof aBase2ExponentialHistogramto the interval[10, 20]instead of the expected[-10, 20].Changes
Fix the double negation so that the function validates correctly. I've also added some tests that exercise the entire validation function.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes