Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http example with json protocol #1912

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

ramgdev
Copy link
Contributor

@ramgdev ramgdev commented Jul 8, 2024

Fixes #
Design discussion issue (if applicable) #

Changes

  • Update http example to enable http-json feature
  • Update code to specify protocol when building http exporter

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@ramgdev ramgdev requested a review from a team as a code owner July 8, 2024 02:46
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.0%. Comparing base (224289e) to head (0e3495f).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1912   +/-   ##
=====================================
  Coverage   75.0%   75.0%           
=====================================
  Files        122     122           
  Lines      20276   20276           
=====================================
  Hits       15221   15221           
  Misses      5055    5055           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@lalitb lalitb merged commit 3882b22 into open-telemetry:main Jul 10, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants