[exporter] Export instrument library information in Jaeger and Zipkin. #243
Conversation
…ent version for Jaeger. According to spec open-telemetry/opentelemetry-specification#800 and open-telemetry/opentelemetry-specification#801, We MUST export instrumentation library information for Jaeger and Zipkin exporter. Use crate version as default Jaeger instrumentation library version in consistent with Zipkin.
TommyCpp
force-pushed
the
instrumentlibrary
branch
from
589be4f
to
b387453
Compare
There was a problem hiding this comment.
These look good, thanks @TommyCpp. Think it may be good to have an option to disable this in the pipeline builder as well, the values are constant and storage-conscious people may not want to have these on all recorded spans. Can do as a follow up pr later if you prefer.
|
@jtescher That's a good idea! I thought about it but the only concern I have was that spec seems pretty insist to include those in tags. Maybe this worth an issue in specifications? |
|
@TommyCpp I think as long as this is the default it's fine to include an opt-out. For example if you are just using otel to send data to jaeger there is no need to include these if you don't want to as jaeger will not treat these values any differently. |
|
Ok I'll merge this for now, can do the opt-out in a follow up |
According to spec open-telemetry/opentelemetry-specification#800 and open-telemetry/opentelemetry-specification#801, We MUST export instrumentation library information for Jaeger and Zipkin exporter.
Also update Jaeger exporter so that the instrumentation version will be set to crate version.