Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml for K8s and OS resource attributes #1057

Merged

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Oct 5, 2020

Fixes #547

Changes

Editorial change.
This PR introduces the YAML definitions of K8s and OS resource attributes.

@thisthat thisthat requested review from a team as code owners October 5, 2020 08:35
@arminru arminru added area:semantic-conventions Related to semantic conventions release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Oct 5, 2020
semantic_conventions/resource/k8s.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/k8s.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/k8s.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/k8s.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/k8s.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/k8s.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/k8s.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/k8s.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/os.yaml Outdated Show resolved Hide resolved
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arminru arminru merged commit 30ea75e into open-telemetry:master Oct 9, 2020
@arminru arminru deleted the yaml-resource-k8s-os branch October 9, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Define semantic conventions in JSON/YAML
3 participants