Add OTEL_TRACE_SAMPLER. #1136
Merged
Add OTEL_TRACE_SAMPLER. #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
added
area:sdk
arminru
reviewed
Oct 23, 2020
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
arminru
reviewed
Oct 23, 2020
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
|
@open-telemetry/specs-approvers Please review this ;) |
jmacd
approved these changes
Oct 27, 2020
andrewhsu
removed
priority:p2
|
looks like this PR is blocking PR #1117 |
|
@open-telemetry/java-instrumentation-approvers @open-telemetry/python-approvers as you work on auto-instrumentation components, would you mind reviewing this and verify it's all good? |
codeboten
approved these changes
Oct 28, 2020
ocelotl
approved these changes
Oct 28, 2020
|
Merging this is as 1) has enough reviews, 2) we need this merged before proceeding with #1105 and 3) It's minimalistic enough. Let's follow up any missing detail if/as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
OTEL_TRACE_SAMPLER, required for properly resolving #1105 .This is a super minimalistic, but hopefully correct approach. Following @jmacd's comment about the possibility of adding sampling for metrics in the future, I added
TRACEin it.