Rename cloud.zone to cloud.availability_zone #1495
Merged
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
reviewed
Mar 3, 2021
reyang
reviewed
Mar 3, 2021
reyang
approved these changes
Mar 3, 2021
iNikem
approved these changes
Mar 3, 2021
anuraaga
approved these changes
Mar 3, 2021
Oberon00
approved these changes
Mar 3, 2021
alolita
approved these changes
Mar 3, 2021
arminru
approved these changes
Mar 3, 2021
|
PTAL |
yurishkuro
reviewed
Mar 3, 2021
Only Google Cloud calls availability zones a zone. Renaming zone to make the least common case an exception. This change is a follow-up of #1481.
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
|
We discussed in the meeting and decided that readability matters more. We always have a way to compress the keys in the future on the wire and at rest if it's needed. This change should be good to be merged. I will also send a change with recommendations on max key lengths as a guideline as we discussed earlier. |
jrcamp
added a commit
to jrcamp/opentelemetry-collector
that referenced
this pull request
Mar 25, 2021
cloud.infrastructure_service -> cloud.platform cloud.zone -> cloud.availability_zone These changes were made in: open-telemetry/opentelemetry-specification#1495 open-telemetry/opentelemetry-specification#1530 Will make changes in contrib next.
jrcamp
added a commit
to jrcamp/opentelemetry-collector
that referenced
this pull request
Mar 25, 2021
cloud.infrastructure_service -> cloud.platform cloud.zone -> cloud.availability_zone These changes were made in: open-telemetry/opentelemetry-specification#1495 open-telemetry/opentelemetry-specification#1530 Will make changes in contrib next.
jrcamp
added a commit
to jrcamp/opentelemetry-collector
that referenced
this pull request
Mar 25, 2021
cloud.infrastructure_service -> cloud.platform cloud.zone -> cloud.availability_zone These changes were made in: open-telemetry/opentelemetry-specification#1495 open-telemetry/opentelemetry-specification#1530 Will make changes in contrib next.
bogdandrutu
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Mar 25, 2021
* Updates for cloud semantic conventions cloud.infrastructure_service -> cloud.platform cloud.zone -> cloud.availability_zone These changes were made in: open-telemetry/opentelemetry-specification#1495 open-telemetry/opentelemetry-specification#1530 Will make changes in contrib next. * fix oc conversion
ThomsonTan
pushed a commit
to ThomsonTan/opentelemetry-specification
that referenced
this pull request
Mar 30, 2021
Co-authored-by: Christian Neumüller <christian+github@neumueller.me> Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only Google Cloud calls availability zones a zone. Renaming zone
to make the least common case an exception.
This change is a follow-up of #1481.