Avoid using "infrastructure" terminology for all cloud #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Mar 11, 2021
Infrastructure in cloud has a specific connotation for concepts explained in Infrastructure-as-a-Service (IaaS). Avoid this termilogy because it's exclusive of some other services/platforms that is represented by the "cloud" namespace. Renaming "infrastructure_service" to "service" also due to the new key length limits we are considering and infrastructure_service is a lengthy choice.
|
PTAL |
reyang
approved these changes
Mar 12, 2021
anuraaga
approved these changes
Mar 12, 2021
bogdandrutu
approved these changes
Mar 15, 2021
Oberon00
reviewed
Mar 15, 2021
| @@ -42,7 +42,7 @@ groups: | |||
| note: > | |||
| Availability zones are called "zones" on Google Cloud. | |||
| examples: ['us-east-1c'] | |||
| - id: infrastructure_service | |||
| - id: platform | |||
There was a problem hiding this comment.
The only hits I get on google for "Cloud platform" is GCP as a whole...
Oberon00
approved these changes
Mar 15, 2021
bogdandrutu
reviewed
Mar 16, 2021
|
Ping @rakyll (it looks there are a pair of unaddressed comments) |
jrcamp
added a commit
to jrcamp/opentelemetry-collector
that referenced
this pull request
Mar 25, 2021
cloud.infrastructure_service -> cloud.platform cloud.zone -> cloud.availability_zone These changes were made in: open-telemetry/opentelemetry-specification#1495 open-telemetry/opentelemetry-specification#1530 Will make changes in contrib next.
jrcamp
added a commit
to jrcamp/opentelemetry-collector
that referenced
this pull request
Mar 25, 2021
cloud.infrastructure_service -> cloud.platform cloud.zone -> cloud.availability_zone These changes were made in: open-telemetry/opentelemetry-specification#1495 open-telemetry/opentelemetry-specification#1530 Will make changes in contrib next.
jrcamp
added a commit
to jrcamp/opentelemetry-collector
that referenced
this pull request
Mar 25, 2021
cloud.infrastructure_service -> cloud.platform cloud.zone -> cloud.availability_zone These changes were made in: open-telemetry/opentelemetry-specification#1495 open-telemetry/opentelemetry-specification#1530 Will make changes in contrib next.
bogdandrutu
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Mar 25, 2021
* Updates for cloud semantic conventions cloud.infrastructure_service -> cloud.platform cloud.zone -> cloud.availability_zone These changes were made in: open-telemetry/opentelemetry-specification#1495 open-telemetry/opentelemetry-specification#1530 Will make changes in contrib next. * fix oc conversion
ThomsonTan
pushed a commit
to ThomsonTan/opentelemetry-specification
that referenced
this pull request
Mar 30, 2021
…y#1530) * Avoid using "infrastructure" terminology for all cloud Infrastructure in cloud has a specific connotation for concepts explained in Infrastructure-as-a-Service (IaaS). Avoid this termilogy because it's exclusive of some other services/platforms that is represented by the "cloud" namespace. Renaming "infrastructure_service" to "service" also due to the new key length limits we are considering and infrastructure_service is a lengthy choice.
|
BTW, since renaming is essentially a braking change, how should it work for specs v1.0+? |
Hopefully once Telemetry Schemas are implemented renaming can be handled though them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infrastructure in cloud has a specific connotation for concepts
explained in Infrastructure-as-a-Service (IaaS). Avoid this
terminology because it's exclusive of some other services/platforms
that is represented by the "cloud" namespace.
Renaming "infrastructure_service" to "platform" also due to the new
key length limits we are considering and infrastructure_service is
a lengthy choice.