Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details for filling resource for AWS Lambda. #1610

Merged
merged 6 commits into from
Apr 15, 2021

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Apr 9, 2021

Changes

Adds details for mapping environment variables to resource values for AWS Lambda.

Related issues #

Related oteps #

@anuraaga anuraaga requested a review from a team as a code owner April 9, 2021 07:21
@anuraaga anuraaga requested a review from a team April 9, 2021 07:21
@anuraaga anuraaga requested a review from a team as a code owner April 9, 2021 07:21

## Resource Detector

AWS Lambda resource information is available as environment variables provided by the runtime.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this documented somewhere? Could we add a link to the documentation, if it exists at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, added


## Resource Detector

AWS Lambda resource information is available as [environment variables][] provided by the runtime.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing link for the environment variables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's below as an out-of-band link

@carlosalberto carlosalberto merged commit 7030952 into open-telemetry:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants