Fixes monotonicity issues we have implementing the specification. #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent negative measurements in Histogram Instruments so we
can include monotonic sum in the data and export to prometheus.
- Remove explicit monotonicity argument to aggregators and always infer
from instrument type.
- Expand list of supported instruments for Sum aggregation with details
on default aggregation.
- Add note on handling `sum` in histogram for instruments that allow
negative measurements.
aabmass
reviewed
Oct 12, 2021
reyang
approved these changes
Oct 12, 2021
reyang
added
area:sdk
reyang
changed the title
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
jmacd
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Looks good to me. If there is demand for a histogram of signed measurements, my preference then would be to add a field to encode the primitive measurement type (which is either Counter, UpDownCounter, or Gauge, in which case the Sum is not necessarily well-defined for Gauge histograms, as I wrote in open-telemetry/oteps#156).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2009
Changes
can include monotonic sum in the data and export to prometheus.
from instrument type.
on default aggregation.
sumin histogram for instruments that allownegative measurements.
Related issues:
sumto present with negative measurements in Histogram opentelemetry-proto#303