Define the instrumentation library name for the OT Shim. #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Dec 16, 2021
yurishkuro
approved these changes
Dec 16, 2021
jmacd
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an item in #2147
Currently the Spec says that a
Tracershould be supplied when creating an OT Shim, although both Java and Python require aTracerProviderinstead:opentelemetry-opentracing-shimas instrumentation library.opentracingshimas instrumentation library.Tracer.I think it would be a good thing to use a single name for the Shim (as it's the same component, just in different languages), but would love to hear opinions.
cc @yurishkuro