Remove work_in_progress dir #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c24t
requested review from
AloisReitbauer,
bogdandrutu,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
bogdandrutu
approved these changes
Aug 20, 2019
songy23
approved these changes
Aug 20, 2019
reyang
approved these changes
Aug 20, 2019
|
Sounds like this is ready to be merged? |
|
Going to merge this, if anyone feels like some of the files are needed again we can recover them. |
bg451
pushed a commit
to bg451/opentelemetry-specification
that referenced
this pull request
Sep 9, 2019
Signed-off-by: Brandon Gonzalez <bg@lightstep.com>
yurishkuro
pushed a commit
that referenced
this pull request
Sep 13, 2019
* Removes references of spandata Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * initial stab at tracing spec Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * adds link and event timestamp Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * re-add whitespace to reduce diff size Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * typo fix Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Adds OutOfBand flag to span options Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * specification/api-distributedcontext: fix typo (#236) contest -> context Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Adds comment+link to Remove Out Of Band Support RFC Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * remove comment in doc Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Remove work_in_progress dir (#225) Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Move start timestamp above the possibly removed fields Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Fix typo in FailedNotRetryable (#243) Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Rename TraceOptions to TraceFlags to be w3c compatible (#234) * Rename TraceOptions to TraceFlags to be w3c compatible Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Fix more TraceOptions and rename recorded with sampled Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Respond to comment
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Removes references of spandata Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * initial stab at tracing spec Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * adds link and event timestamp Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * re-add whitespace to reduce diff size Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * typo fix Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Adds OutOfBand flag to span options Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * specification/api-distributedcontext: fix typo (open-telemetry#236) contest -> context Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Adds comment+link to Remove Out Of Band Support RFC Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * remove comment in doc Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Remove work_in_progress dir (open-telemetry#225) Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Move start timestamp above the possibly removed fields Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Fix typo in FailedNotRetryable (open-telemetry#243) Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Rename TraceOptions to TraceFlags to be w3c compatible (open-telemetry#234) * Rename TraceOptions to TraceFlags to be w3c compatible Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Fix more TraceOptions and rename recorded with sampled Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Brandon Gonzalez <bg@lightstep.com> * Respond to comment
TuckTuckFloof
pushed a commit
to TuckTuckFloof/opentelemetry-specification
that referenced
this pull request
Oct 15, 2020
jack-berg
added a commit
that referenced
this pull request
Apr 12, 2023
Initial followup to [OTEP #225](open-telemetry/oteps#225). This lays the initial groundwork for file configuration in the specification. There are placeholders TODOs for many various followup tasks. Additional work is also needed to figure out how to merge [SDK Configuration](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-configuration.md), [SDK Environment Variables](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md) and file configuration into a cohesive story. This PR proposes the configuration schema live in `opentelemetry-specification/specification/configuration/schema/`, which implies that at some point additional build steps will be needed to confirm changes to the schema are valid and allowed. cc @MrAlias, @codeboten
jack-berg
added a commit
that referenced
this pull request
Oct 16, 2023
Part of incorporating [OTEP #225](open-telemetry/oteps#225) into the specification. Followup to #3360.
jack-berg
added a commit
that referenced
this pull request
Dec 14, 2023
Part of incorporating [OTEP #225](open-telemetry/oteps#225) into the specification. Followup to #3437. The adds the YAML file format, and leaves an open TODO for the JSON format discussed in the original OTEP. It also define environment variable substitution. IMO its necessary to define environment variable substitution at the same time as file format because they interact in ways that aren't immediately obvious and need to be prototyped. The opentelemetry-java implementation of file configuration already accepts YAML encoding and performs environment variable substitution as described in this PR. It does not support JSON, and I don't think we should unless there is good reason. I omitted the JSON file format because I don't know of any prototypes that permit it. We should add JSON once a language implements it and explores how environment variable substitution works with JSON.
jack-berg
added a commit
that referenced
this pull request
Jan 29, 2024
Part of incorporating [OTEP #225](open-telemetry/oteps#225) into the specification. Followup to #3744. This defines how file configuration works with custom SDK extension components (Samplers, Exporters, etc). It defines the concept of a Component Provider: - Component providers are registered with the type of extension component they provide and a name. Component providers are registered automatically or manually based on what is idiomatic in the language. - Component providers have a Create Plugin method, which passes configuration properties as a parameter and returns the configured component - When Create is called to interpret a file configuration model, and it comes across a reference to a extension component which is not built-in, it invokes Create Plugin on the corresponding component provider. If no corresponding component provider exists, or if Create Plugin returns an Error, Create returns an error. Prototype implementation in java here: open-telemetry/opentelemetry-java-examples#227 cc @open-telemetry/configuration-maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
work_in_progress, which has outlived its usefulness now that we've bootstrapped most components of the spec. These docs are still available in git history or the original OpenCensus and OpenTelemetry specs, we don't need to keep them for reference here.