Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flush method on LogEmitter #2405

Merged
merged 6 commits into from
Mar 21, 2022

Conversation

srikanthccv
Copy link
Member

Fixes #2342

Changes

This change proposes to remove the flush on Emitter for the consistency. There is no flush on Tracer/Meter specification. Language sdk implementations may choose the idiomatic way to provide the appender/handler ability to call flush on the LogEmitterProvider (ex: setter in java, init arg in py, or possibly a global accessor for provider etc...)

@srikanthccv srikanthccv marked this pull request as ready for review March 6, 2022 13:11
@srikanthccv srikanthccv requested review from a team as code owners March 6, 2022 13:11
@srikanthccv srikanthccv requested a review from a team March 6, 2022 13:11
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but also need confirmation at least from @jack-berg

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of removing the flush method as originally discussed here 👍

@tigrannajaryan tigrannajaryan merged commit 441bafa into open-telemetry:main Mar 21, 2022
@pranavmarla
Copy link

pranavmarla commented Aug 5, 2022

Fixes #2342

Changes

This change proposes to remove the flush on Emitter for the consistency. There is no flush on Tracer/Meter specification. Language sdk implementations may choose the idiomatic way to provide the appender/handler ability to call flush on the LogEmitterProvider (ex: setter in java, init arg in py, or possibly a global accessor for provider etc...)

FYI, the following link from the original post is now dead:

ex: setter in java

So here is an updated permalink: setter in java

@srikanthccv srikanthccv deleted the issue-2342 branch September 12, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is LogEmitter.flush necessary?
5 participants