Definition of boolean environment variables on the SDK #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Aug 29, 2022
jack-berg
reviewed
Aug 29, 2022
arminru
added
area:sdk
arminru
reviewed
Aug 30, 2022
Aneurysm9
reviewed
Aug 30, 2022
brunobat
force-pushed
the
boolean-definition
branch
3 times, most recently
from
607dac2
to
97af404
Compare
Aneurysm9
reviewed
Aug 31, 2022
jack-berg
approved these changes
Sep 2, 2022
arminru
approved these changes
Sep 2, 2022
marcalff
suggested changes
Sep 3, 2022
marcalff
suggested changes
Sep 3, 2022
reyang
reviewed
Sep 6, 2022
reyang
reviewed
Sep 6, 2022
reyang
approved these changes
Sep 6, 2022
brunobat
force-pushed
the
boolean-definition
branch
from
97af404
to
1ad8bb1
Compare
brunobat
force-pushed
the
boolean-definition
branch
from
c0ab3f0
to
86a8a6a
Compare
MrAlias
approved these changes
Sep 13, 2022
marcalff
approved these changes
Sep 13, 2022
MSNev
approved these changes
Sep 20, 2022
dyladan
approved these changes
Sep 20, 2022
jack-berg
approved these changes
Sep 21, 2022
Signed-off-by: brunobat <brunobat@gmail.com>
Signed-off-by: brunobat <brunobat@gmail.com>
Signed-off-by: brunobat <brunobat@gmail.com>
Signed-off-by: brunobat <brunobat@gmail.com>
Signed-off-by: brunobat <brunobat@gmail.com>
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Signed-off-by: brunobat <brunobat@gmail.com>
brunobat
force-pushed
the
boolean-definition
branch
from
505cd2d
to
966634f
Compare
|
@jmacd I think this is ready now |
This was referenced Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: brunobat brunobat@gmail.com
Fixes #2729
Present PR is based on the issue's discussion.
Changes
Adds the definition of a boolean environment variables to the SDK.
Related issues
Make OTEL_EXPERIMENTAL_SDK_ENABLED stable