Prometheus histogram bucket metric ends in _bucket #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gouthamve @jmacd |
|
cc @open-telemetry/wg-prometheus |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
@carlosalberto can you reopen? |
jack-berg
approved these changes
Jan 4, 2023
jmacd
approved these changes
Jan 10, 2023
reyang
approved these changes
Jan 10, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
dashpole
force-pushed
the
histogram_bucket
branch
from
54857dc
to
49994eb
Compare
dashpole
force-pushed
the
histogram_bucket
branch
from
49994eb
to
3bf5d1d
Compare
|
I believe this can be merged. |
MrAlias
approved these changes
Jan 20, 2023
Aneurysm9
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized when opening open-telemetry/opentelemetry-swift#355 that the current prometheus spec for histograms is incorrect (though almost all implementations of prometheus exporters is correct).
From the prometheus spec:
From the OpenMetrics spec:
This corrects our specification to be in-line with prometheus and OM specs