Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add semantic conventions for heroku #3075

Merged
merged 21 commits into from
Feb 27, 2023
Merged

add semantic conventions for heroku #3075

merged 21 commits into from
Feb 27, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 4, 2023

Fixes #3032

Changes

Adds a list of resource attributes characterizing a Heroku dyno environment, taken after https://devcenter.heroku.com/articles/dyno-metadata

@atoulme atoulme requested review from a team as code owners January 4, 2023 23:26
@atoulme atoulme mentioned this pull request Jan 7, 2023
Closed
joaopgrassi
joaopgrassi reviewed Jan 9, 2023
View reviewed changes
semantic_conventions/resource/heroku.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/heroku.yaml Outdated Show resolved Hide resolved
specification/resource/semantic_conventions/heroku.md Outdated Show resolved Hide resolved
semantic_conventions/resource/heroku.yaml Outdated Show resolved Hide resolved
@arminru arminru added area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory labels Jan 10, 2023
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 18, 2023
@joaopgrassi
Copy link
Member

I just noticed, shouldn't these new conventions be inside the cloud provider's folder? https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/resource/semantic_conventions/cloud_provider

@atoulme
Copy link
Contributor Author

atoulme commented Jan 18, 2023

I don’t know. Please tell me where this should go. Thanks!

@joaopgrassi
Copy link
Member

I'm not sure as well, but I'd think Heroku is a cloud provider, so would make sense to be in that folder? Not sure if the others think the same.

@github-actions github-actions bot removed the Stale label Jan 19, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 2, 2023
@arminru arminru removed the Stale label Feb 3, 2023
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 11, 2023
@atoulme
Copy link
Contributor Author

atoulme commented Feb 19, 2023 •
edited

/label -stale

@github-actions github-actions bot removed the Stale label Feb 20, 2023
@atoulme atoulme mentioned this pull request Feb 22, 2023
Closed
@arminru arminru merged commit 361c949 into open-telemetry:main Feb 27, 2023
jsuereth pushed a commit to jsuereth/opentelemetry-specification that referenced this pull request Feb 28, 2023
@atoulme @arminru @jsuereth
add semantic conventions for heroku (open-telemetry#3075)
ab0db31 
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@arminru arminru arminru approved these changes

@MovieStoreGuy MovieStoreGuy MovieStoreGuy approved these changes

Assignees

@yurishkuro yurishkuro

Labels
area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add heroku dyno resource attributes
5 participants
@atoulme @joaopgrassi @arminru @MovieStoreGuy @yurishkuro