Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add heroku dyno resource attributes #3032

Closed
atoulme opened this issue Dec 14, 2022 · 1 comment · Fixed by #3075
Closed

Add heroku dyno resource attributes #3032

atoulme opened this issue Dec 14, 2022 · 1 comment · Fixed by #3075
Assignees
@carlosalberto
Labels
area:semantic-conventions Related to semantic conventions [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:resource Related to the specification/resource directory

Comments

@atoulme
Copy link
Contributor

atoulme commented Dec 14, 2022

What are you trying to achieve?
I want to add a list of resource attributes characterizing a Heroku dyno environment, taken after https://devcenter.heroku.com/articles/dyno-metadata

Additional context.

I am in the process of contributing to the resource detection processor support for Heroku with open-telemetry/opentelemetry-collector-contrib#16840

See tracking issue here: open-telemetry/opentelemetry-collector-contrib#16833
@atoulme atoulme added the spec:resource Related to the specification/resource directory label Dec 14, 2022
@arminru arminru added the area:semantic-conventions Related to semantic conventions label Dec 15, 2022
@djaglowski djaglowski added the [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR label Jan 4, 2023
@atoulme atoulme mentioned this issue Jan 4, 2023
Merged
@atoulme
Copy link
Contributor Author

atoulme commented Jan 7, 2023

This issue has received 3 +1, therefore I have opened a PR #3075.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosalberto carlosalberto

Labels
area:semantic-conventions Related to semantic conventions [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:resource Related to the specification/resource directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add semantic conventions for heroku atoulme/opentelemetry-specification
4 participants
@atoulme @carlosalberto @djaglowski @arminru