Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTEL_EXPORTER_OTLP_SPAN_INSECURE and OTEL_EXPORTER_OTLP_METRIC_INSECURE are not required for new implementations #3719

Merged
merged 6 commits into from Oct 18, 2023
Merged

OTEL_EXPORTER_OTLP_SPAN_INSECURE and OTEL_EXPORTER_OTLP_METRIC_INSECURE are not required for new implementations #3719

merged 6 commits into from Oct 18, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Oct 12, 2023 •
edited

Fixes #3717

Based on the information provided in #2240, it appears that the author (@tsloughter) intended to convey that OTEL_EXPORTER_OTLP_SPAN_INSECURE and OTEL_EXPORTER_OTLP_METRIC_INSECURE are older environment variables, and if they were previously implemented, they should continue to be supported. It's implied that new implementations may not necessarily need to support OTEL_EXPORTER_OTLP_SPAN_INSECURE and OTEL_EXPORTER_OTLP_METRIC_INSECURE.

@pellared pellared changed the title OTEL_EXPORTER_OTLP_SPAN_INSECURE and OTEL_EXPORTER_OTLP_METRIC_INSECU… OTEL_EXPORTER_OTLP_SPAN_INSECURE and OTEL_EXPORTER_OTLP_METRIC_INSECURE are not required for new implementations Oct 12, 2023
@pellared pellared mentioned this pull request Oct 12, 2023
Closed
@pellared pellared marked this pull request as ready for review October 12, 2023 11:27
@pellared pellared requested review from a team as code owners October 12, 2023 11:27
trask
trask approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

MrAlias
MrAlias approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of making the recommendation normative.

specification/protocol/exporter.md Outdated Show resolved Hide resolved
pellared and others added 2 commits October 17, 2023 08:01
@pellared @MrAlias
Update specification/protocol/exporter.md
ab76446 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@pellared
Merge branch 'main' into patch-8
9275ae0
@pellared pellared mentioned this pull request Oct 18, 2023
Closed
@reyang reyang merged commit c6e9a24 into open-telemetry:main Oct 18, 2023
7 checks passed
@pellared pellared deleted the patch-8 branch October 18, 2023 15:52
@tigrannajaryan tigrannajaryan mentioned this pull request Oct 18, 2023
Closed
@pellared pellared mentioned this pull request Nov 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@MrAlias MrAlias MrAlias approved these changes

@reyang reyang reyang approved these changes

Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@pellared @trask @carlosalberto @MrAlias @reyang @yurishkuro