Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editorial] Fix links: rename anchor id to event-data-model #4075

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 11, 2024

/cc @open-telemetry/docs-maintainers

@chalin chalin requested review from a team as code owners June 11, 2024 16:36
@chalin chalin requested a review from a team June 11, 2024 16:36
@reyang reyang added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Jun 11, 2024
@chalin
Copy link
Contributor Author

chalin commented Jun 11, 2024

It would be nice to get errors like these caught before a new version of the spec lands on the website, but I'm not sure what to propose to address / check hashes (which this repo's link checker seems to ignore). Any ideas @open-telemetry/specs-approvers @open-telemetry/docs-approvers?

@trask
Copy link
Member

trask commented Jun 11, 2024

It would be nice to get errors like these caught before a new version of the spec lands on the website, but I'm not sure what to propose to address / check hashes (which this repo's link checker seems to ignore). Any ideas @open-telemetry/specs-approvers @open-telemetry/docs-approvers?

related: open-telemetry/semantic-conventions#1009

@chalin chalin changed the title [editorial] Rename invalid hashes [editorial] Fix links: rename anchor id to event-data-model Jun 13, 2024
@reyang reyang merged commit 0fbf6c8 into open-telemetry:main Jun 13, 2024
6 checks passed
@chalin chalin deleted the chalin-im-event-data-model-2024-06-11 branch June 13, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants