Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a comment that End doesn't End children Spans #63

Merged
merged 2 commits into from
Jun 3, 2019
Merged

added a comment that End doesn't End children Spans #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
354e3cb
added a comment that End doesn't End children Spans
Jun 3, 2019
5e411ea
Merge branch 'master' into endDoesntEndKids
SergeyKanzhelev Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion specification/tracing-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,15 @@ Required parameters:
- The new **operation name**, which supersedes whatever was passed in when the
`Span` was started

#### `End`: finish the `Span`
#### End

Finish the `Span`. This call will take the current timestamp to set as `Span`'s
end time. Implementations MUST ignore all subsequent calls to `End` (there might
be exceptions when Tracer is streaming event and has no mutable state associated
with the `Span`).

Call to `End` of a `Span` MUST not have any effects on child spans. Those may
still be running and can be ended later.

There should be no parameters.

Expand Down