Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic conventions for container id #673

Merged
merged 4 commits into from
Jun 30, 2020

Conversation

wangzlei
Copy link
Contributor

Currently Container Attributes in Resource have only container.name to represent the container instance. I am proposing adding container.id as a Container attribute.
Refer to docker documentation Container identification, Container's full-id, short-id and name are equivalent in docker CLI like 'docker info '. name is usually human readable and can be changed by command 'docker rename' during runtime.

And AWS X-ray uses container.id represent the container instance in ECS, adding container.id in OpenTelemetry would be great helpful for X-Ray.

@wangzlei wangzlei requested a review from a team as a code owner June 25, 2020 21:31
@wangzlei wangzlei closed this Jun 26, 2020
@wangzlei wangzlei reopened this Jun 28, 2020
wangzlei and others added 2 commits June 29, 2020 11:33
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants