-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve fibonacci code in Getting Started page #2901
Conversation
Also please check https://github.com/open-telemetry/opentelemetry.io/actions/runs/5342310912/jobs/9684106429?pr=2901 EDIT: I guess you should use "tabs" 😬 |
7290712
to
66f3f23
Compare
This should not have been merged. The error was intentional. It is addressed in a later section: https://github.com/MitchellGale/opentelemetry.io/blob/806d4094e6a1fcf6ce681643dad0f86b534853e2/content/en/docs/instrumentation/go/getting-started.md#bonus-errors Having this error is important as it helps instruct users how to handle errors with their traces. |
The Fibonacci demo on the getting started page does not account for overflows. This fix improves it by throwing an error upon overflow (fib 94 or above for uint64).
Old:
New: