Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve fibonacci code in Getting Started page" #2906

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jun 26, 2023

Reverts #2901

The error is intentional so its fix can be used later to instruct users how to add errors to spans: https://github.com/MitchellGale/opentelemetry.io/blob/806d4094e6a1fcf6ce681643dad0f86b534853e2/content/en/docs/instrumentation/go/getting-started.md#bonus-errors

@MrAlias MrAlias requested review from a team as code owners June 26, 2023 14:21
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrAlias Sorry for not catching when reviewing #2901

@svrnm
Copy link
Member

svrnm commented Jun 26, 2023

@MrAlias Sorry for not catching when reviewing #2901

Apologies from my site as well, but let's revert it now!

@svrnm svrnm merged commit 49934e4 into main Jun 26, 2023
8 checks passed
@svrnm svrnm deleted the revert-2901-integ/fix-fib branch June 26, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants