Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrentbatchprocessor sharding by metadataKeys #183

Closed
moh-osman3 opened this issue May 7, 2024 · 0 comments · Fixed by #184
Closed

Fix concurrentbatchprocessor sharding by metadataKeys #183

moh-osman3 opened this issue May 7, 2024 · 0 comments · Fixed by #184

Comments

@moh-osman3
Copy link
Contributor

moh-osman3 commented May 7, 2024 •
edited
Loading

Currently multiShardBatcher does not work as intended because we are dropping the shard's exportCtx on the floor. This has the effect of failing to propogate metadata keys to downstream collector components.
@moh-osman3 moh-osman3 mentioned this issue May 7, 2024
Merged
@jmacd jmacd closed this as completed in #184 May 7, 2024
jmacd pushed a commit that referenced this issue May 7, 2024
@moh-osman3
(concurrentbatchprocessor): propagate metadataKeys correctly when usi…
dc5112b 
…ng `multiShardBatcher` (#184)

Resolves #183

The bug in the processor was simply dropping `b.exportCtx` (the shard
specific export context that contains the metadata keys), so
metadataKeys were not getting passed along to the next component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@moh-osman3