(concurrentbatchprocessor): propagate metadataKeys correctly when using multiShardBatcher
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moh-osman3
changed the title
multiShardBatcher
moh-osman3
force-pushed
the
mohosman/cbp-keep-parent
branch
from
b14f2cc
to
25dd516
Compare
jmacd
approved these changes
May 7, 2024
codeboten
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
May 14, 2024
…or to v0.23.0 (#33055) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/open-telemetry/otel-arrow/collector](https://togithub.com/open-telemetry/otel-arrow) | `v0.22.0` -> `v0.23.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>open-telemetry/otel-arrow (github.com/open-telemetry/otel-arrow/collector)</summary> ### [`v0.23.0`](https://togithub.com/open-telemetry/otel-arrow/releases/tag/v0.23.0) [Compare Source](https://togithub.com/open-telemetry/otel-arrow/compare/v0.22.0...v0.23.0) ##### What's Changed - Update go.mod files post v0.22, restore CI by [@​jmacd](https://togithub.com/jmacd) in [open-telemetry/otel-arrow#180 - (boundedqueue): new semaphore implementation by [@​moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#174 - (concurrentbatchprocessor): propagate metadataKeys correctly when using `multiShardBatcher` by [@​moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#184 - (otelarrowreceiver): asynchronous stream operations by [@​moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#181 - Remove the FIFO prioritizer; use least-loaded over all streams by default by [@​jmacd](https://togithub.com/jmacd) in [open-telemetry/otel-arrow#186 - Lint fixes from open collector-contrib PRs. by [@​jmacd](https://togithub.com/jmacd) in [open-telemetry/otel-arrow#188 - Release otel-arrow v0.23.0 by [@​moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#187 **Full Changelog**: open-telemetry/otel-arrow@v0.22.0...v0.23.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
May 16, 2024
…3.0 (#33050) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/open-telemetry/otel-arrow](https://togithub.com/open-telemetry/otel-arrow) | `v0.22.0` -> `v0.23.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>open-telemetry/otel-arrow (github.com/open-telemetry/otel-arrow)</summary> ### [`v0.23.0`](https://togithub.com/open-telemetry/otel-arrow/releases/tag/v0.23.0) [Compare Source](https://togithub.com/open-telemetry/otel-arrow/compare/v0.22.0...v0.23.0) ##### What's Changed - Update go.mod files post v0.22, restore CI by [@​jmacd](https://togithub.com/jmacd) in [open-telemetry/otel-arrow#180 - (boundedqueue): new semaphore implementation by [@​moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#174 - (concurrentbatchprocessor): propagate metadataKeys correctly when using `multiShardBatcher` by [@​moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#184 - (otelarrowreceiver): asynchronous stream operations by [@​moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#181 - Remove the FIFO prioritizer; use least-loaded over all streams by default by [@​jmacd](https://togithub.com/jmacd) in [open-telemetry/otel-arrow#186 - Lint fixes from open collector-contrib PRs. by [@​jmacd](https://togithub.com/jmacd) in [open-telemetry/otel-arrow#188 - Release otel-arrow v0.23.0 by [@​moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#187 **Full Changelog**: open-telemetry/otel-arrow@v0.22.0...v0.23.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
](https://renovatebot.com){kind=link}
…or to v0.23.0 (open-telemetry#33055) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/open-telemetry/otel-arrow/collector](https://togithub.com/open-telemetry/otel-arrow) | `v0.22.0` -> `v0.23.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>open-telemetry/otel-arrow (github.com/open-telemetry/otel-arrow/collector)</summary> ### [`v0.23.0`](https://togithub.com/open-telemetry/otel-arrow/releases/tag/v0.23.0) [Compare Source](https://togithub.com/open-telemetry/otel-arrow/compare/v0.22.0...v0.23.0) ##### What's Changed - Update go.mod files post v0.22, restore CI by [@&open-telemetry#8203;jmacd](https://togithub.com/jmacd) in [open-telemetry/otel-arrow#180 - (boundedqueue): new semaphore implementation by [@&open-telemetry#8203;moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#174 - (concurrentbatchprocessor): propagate metadataKeys correctly when using `multiShardBatcher` by [@&open-telemetry#8203;moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#184 - (otelarrowreceiver): asynchronous stream operations by [@&open-telemetry#8203;moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#181 - Remove the FIFO prioritizer; use least-loaded over all streams by default by [@&open-telemetry#8203;jmacd](https://togithub.com/jmacd) in [open-telemetry/otel-arrow#186 - Lint fixes from open collector-contrib PRs. by [@&open-telemetry#8203;jmacd](https://togithub.com/jmacd) in [open-telemetry/otel-arrow#188 - Release otel-arrow v0.23.0 by [@&open-telemetry#8203;moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#187 **Full Changelog**: open-telemetry/otel-arrow@v0.22.0...v0.23.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
…3.0 (open-telemetry#33050) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/open-telemetry/otel-arrow](https://togithub.com/open-telemetry/otel-arrow) | `v0.22.0` -> `v0.23.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>open-telemetry/otel-arrow (github.com/open-telemetry/otel-arrow)</summary> ### [`v0.23.0`](https://togithub.com/open-telemetry/otel-arrow/releases/tag/v0.23.0) [Compare Source](https://togithub.com/open-telemetry/otel-arrow/compare/v0.22.0...v0.23.0) ##### What's Changed - Update go.mod files post v0.22, restore CI by [@&open-telemetry#8203;jmacd](https://togithub.com/jmacd) in [open-telemetry/otel-arrow#180 - (boundedqueue): new semaphore implementation by [@&open-telemetry#8203;moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#174 - (concurrentbatchprocessor): propagate metadataKeys correctly when using `multiShardBatcher` by [@&open-telemetry#8203;moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#184 - (otelarrowreceiver): asynchronous stream operations by [@&open-telemetry#8203;moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#181 - Remove the FIFO prioritizer; use least-loaded over all streams by default by [@&open-telemetry#8203;jmacd](https://togithub.com/jmacd) in [open-telemetry/otel-arrow#186 - Lint fixes from open collector-contrib PRs. by [@&open-telemetry#8203;jmacd](https://togithub.com/jmacd) in [open-telemetry/otel-arrow#188 - Release otel-arrow v0.23.0 by [@&open-telemetry#8203;moh-osman3](https://togithub.com/moh-osman3) in [open-telemetry/otel-arrow#187 **Full Changelog**: open-telemetry/otel-arrow@v0.22.0...v0.23.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #183
The bug in the processor was simply dropping
b.exportCtx(the shard specific export context that contains the metadata keys), so metadataKeys were not getting passed along to the next component.