Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend GenAI system well-known values #1020

Merged

Conversation

TaoChenOSU
Copy link
Contributor

@TaoChenOSU TaoChenOSU commented May 9, 2024

Add more well-known GenAI model providers to the list of possible values that the gen_ai.system attribute can take.

Changes

The following are added:

  • anthropic
  • cohere
  • vertex ai

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

@TaoChenOSU TaoChenOSU requested review from a team as code owners May 9, 2024 05:33
Copy link

linux-foundation-easycla bot commented May 9, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

model/registry/gen-ai.yaml Outdated Show resolved Hide resolved
model/registry/gen-ai.yaml Outdated Show resolved Hide resolved
model/registry/gen-ai.yaml Outdated Show resolved Hide resolved
@TaoChenOSU TaoChenOSU requested review from lmolkova and nirga May 18, 2024 16:26
@TaoChenOSU
Copy link
Contributor Author

I think HuggingFace will be the most controversial one. It's neither a model provider nor a service provider. You can use its inference endpoint but for production people may use their dedicated endpoints, which can be hosted on Azure, AWS or GCP.

@TaoChenOSU
Copy link
Contributor Author

I removed some of the most controversial values. The remaining ones are known to have client SDKs.

Copy link
Contributor

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TaoChenOSU I've run the CI for you, there're some things you need to fix 😅

model/registry/gen-ai.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Could you please also add a changelog entry?
(just add a yaml file in the expected format to .chloggen folder)

See https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#adding-a-changelog-entry

@TaoChenOSU TaoChenOSU requested a review from lmolkova June 4, 2024 15:54
@TaoChenOSU TaoChenOSU requested a review from nirga June 4, 2024 15:54
@lmolkova lmolkova merged commit a2c9cff into open-telemetry:main Jun 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants