-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add db.client.operation.duration metric #735
Merged
lmolkova
merged 20 commits into
open-telemetry:main
from
alanwest:alanwest/db-client-call-metric
Apr 22, 2024
Merged
Add db.client.operation.duration metric #735
lmolkova
merged 20 commits into
open-telemetry:main
from
alanwest:alanwest/db-client-call-metric
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57534de
to
4edbf07
Compare
lmolkova
reviewed
Feb 13, 2024
lmolkova
reviewed
Feb 13, 2024
lmolkova
reviewed
Feb 13, 2024
lmolkova
reviewed
Feb 14, 2024
jmacd
reviewed
Mar 5, 2024
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
trask
reviewed
Apr 5, 2024
trask
reviewed
Apr 8, 2024
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
alanwest
commented
Apr 8, 2024
jack-berg
approved these changes
Apr 19, 2024
trask
approved these changes
Apr 19, 2024
lmolkova
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #512
Changes
Adds a new
db.client.operation.duration
metric with the following attributes:db.system
db.collection.name
db.name
db.operation.name
db.instance.id
network.peer.address
network.peer.port
server.address
server.port
The metric is a histogram with the following default explicit bucket boundaries (see #735 (comment)):
[ 0.001, 0.005, 0.01, 0.05, 0.1, 0.5, 1, 5, 10 ]
Merge requirement checklist
[chore]
[ ] schema-next.yaml updated with changes to existing conventions.