Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit sdk to repo #445

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Commit sdk to repo #445

wants to merge 35 commits into from

Conversation

Vibaswan
Copy link
Collaborator

@Vibaswan Vibaswan commented Sep 11, 2023

Fixes #381
changes to commit python and go gen files to repo

Copy link
Contributor

@ashutshkumr ashutshkumr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please steer off from name sanity ?

  1. We should use a package name refapi for go, python and protobuf. For protobuf SDKs, it would use refapipb
  2. When package name is not provided, we should just use oapi instead of sanity as defaults

@Vibaswan
Copy link
Collaborator Author

can we please steer off from name sanity ?

  1. We should use a package name refapi for go, python and protobuf. For protobuf SDKs, it would use refapipb
  2. When package name is not provided, we should just use oapi instead of sanity as defaults

Have done the changes accordiongly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default proto package name should not be sanity and artifact dir should not be art
3 participants