Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent error scheme #449

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Consistent error scheme #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5049669
fixing errors for python
Vibaswan Sep 12, 2023
845f5ac
clubbing validation errors in python
Vibaswan Sep 13, 2023
0a5ae89
remove go 1.17
Vibaswan Sep 13, 2023
ee44665
made consistenet errors for go SDK
Vibaswan Sep 13, 2023
b9bd42b
Merge branch 'main' into consistent_error_scheme
vhowdhur Sep 15, 2023
367ea95
Merge branch 'main' into consistent_error_scheme
Vibaswan Sep 25, 2023
e2bf0e4
Merge branch 'main' into consistent_error_scheme
Vibaswan Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions openapiart/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ type validation struct {
validationErrors []string
warnings []string
constraints map[string]map[string]Constraints
parentContext []string
}

type Validation interface {
Expand All @@ -268,6 +269,9 @@ type Validation interface {
under_review(message string)
Warnings() []string
addWarnings(message string)
getParentContext() string
addToParentContext(parentName string)
removeCurrentContext()
}

func (obj *validation) validationResult() error {
Expand Down Expand Up @@ -427,6 +431,18 @@ func (obj *validation) validateHexSlice(hex []string) error {
return obj.validateSlice(hex, "hex")
}

func (obj *validation) getParentContext() string {
return strings.Join(obj.parentContext, ".")
}

func (obj *validation) addToParentContext(parentName string) {
obj.parentContext = append(obj.parentContext, parentName)
}

func (obj *validation) removeCurrentContext() {
obj.parentContext = obj.parentContext[:len(obj.parentContext)-1]
}

// TODO: restore behavior
// func (obj *validation) createMap(objName string) {
// if obj.constraints == nil {
Expand Down
Loading
Loading