Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align with models 0.3.1 #49

Merged
merged 4 commits into from
Mar 3, 2021
Merged

align with models 0.3.1 #49

merged 4 commits into from
Mar 3, 2021

Conversation

ajbalogh
Copy link
Contributor

@ajbalogh ajbalogh commented Mar 3, 2021

What: Changes to align with models openapi.yaml version 0.3.1

Need to account for format and model names that conflict with generated classes ending in List.

@lgtm-com
Copy link

lgtm-com bot commented Mar 3, 2021

This pull request fixes 1 alert when merging 99496a3 into 20eb591 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@ajbalogh ajbalogh self-assigned this Mar 3, 2021
@lgtm-com
Copy link

lgtm-com bot commented Mar 3, 2021

This pull request fixes 1 alert when merging e07f64b into 20eb591 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@ashutshkumr ashutshkumr merged commit 5927250 into main Mar 3, 2021
@ashutshkumr ashutshkumr deleted the models-0.3.1-alignment branch March 3, 2021 08:55
@ashutshkumr
Copy link
Contributor

@ajbalogh wouldn't SnappiIter (base class) and ObjIter (derived class) be more appropriate ? We also have lesser chances of seeing Iter in node names.

@ajbalogh
Copy link
Contributor Author

ajbalogh commented Mar 3, 2021

I agree - let me open an issue and align with that naming convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants