Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] chai plugins #729

Closed
3 tasks
nweldev opened this issue Aug 13, 2019 · 6 comments · Fixed by #742
Closed
3 tasks

[testing] chai plugins #729

nweldev opened this issue Aug 13, 2019 · 6 comments · Fixed by #742

Comments

@nweldev
Copy link
Contributor

nweldev commented Aug 13, 2019

Using chai plugins with @open-wc/testing is tedious and undocumented.

root cause & context

Chai and most chai plugins aren't exposed as es modules.

This led to the creation of @bundled-es-modules/chai and the following issues:

Thankfully, there still is some Chai Plugins which support ESM:

But these projects don't seem to be actively maintained anymore. So, there isn't any advancement on this right now.

current options

Developers using @open-wc/testing do not have many good options when using chai plugins.

A. esm fork

👉 nathanboktae/chai-dom#38 (comment)

B. define plugins globally

Most chai plugins (chai-dom, sinon-chai, chai-datetime) fall back to using window.chai.use when AMD, CommonJS, etc... aren't available:

Some others, like chai-http, only provide a "global import" syntax. We can use those the same way as showen bellow, by using a static import statement and then calling chai.use.

So, we can:

  1. install the "official" (non esm) packages
    npm i -D chai-dom sinon-chai

  2. import chai from bundled-esm-modules/chai, add it to window.chai, and then dynamically import the plugins packages:

https://github.com/noelmace/devcards/blob/cf0fe84deb338c47699b2aa289100b9834a68e84/test/utils/chai-plugins.js#L1-L6

FYI, window.chai doesn't exist in the imported package if you use static import statements instead, but I don't see any workaround for that.

  1. add this file to karma files:

https://github.com/noelmace/devcards/blob/cf0fe84deb338c47699b2aa289100b9834a68e84/karma.owc.conf.js#L8-L9

proposals for resolution

  1. I feel like option B is the best workaround right now. We could add it to the doc. What do you think?
  2. Regarding option A, as most Chai plugins aren't maintained anymore, and owners don't answer issues, @open-wc / @daKmoR & folks, could provide some esm-modules forks (at least for chai-dom and sinon-chai) and actively maintain those.

BTW, I'm personally concerned about Chai and its plugins maintenance. Even if they are way more popular right now, this is why I tend to favor jasmine for WC testing. Could you explain why Mocha/Chai was chosen for open-wc/testing in the first place?

@daKmoR
Copy link
Member

daKmoR commented Aug 16, 2019

the status of chai plugins is the same as for many other libraries when it comes to es modules... adoption is slow as node is the primary target for many... and node by default still does not support es modules 😭

if there is a simple way to use the "normal" chai and not a bundled-es-modules version then we should totally do and recommend that... 🤗
if we can't do it for chai but somehow we can do it for plugins - that also would be a win 👍

so if you could do a PR for option B that would be awesome 💪

Just to be sure our primary goal is still to test code natively in the browser (e.g. no transformations* or adjustments to the code before it gets shipped to the browser)**.

Could you explain why Mocha/Chai was chosen for open-wc/testing in the first place?

According to our defined goal of using native es modules without any transformations in the browser mocha/chai was our best bet (back then I knew at least how to make es modules work in mocha; while I did not know it for jasmine) how is support for es modules in jasmine nowadays?

* with the exception of bare module
** when testing on older browsers transformations are applied

@nweldev
Copy link
Contributor Author

nweldev commented Aug 16, 2019

The jasmine framework doesn't need any transformation to the code if you use Karma-jasmine with karma-esm, but the CLI doesn't support ESM for now. See my comment on the related issue ☝️

It actually does even less transformation to your source code than Chai/Mocha.

Here is an example:

source file
import { css, html } from '../../utils/tags.js';
import { cardHtml } from '../flashcard/flashcard.js';

/**
 * Web Component representing a stacked flashcard deck
 */
class CardStackComponent extends HTMLElement {
  constructor() {
    super();

    const shadowRoot = this.attachShadow({ mode: 'open' });

    const style = document.createElement('style');

    style.innerText = css`
      .card-wrapper {
        height: 0;
        margin-top: -5px;
      }

      .cards-stack {
        height: calc(var(--card-width) * 1.39);
      }

      dc-flashcard {
        height: 500px;
        width: 300px;
        overflow: scroll;
      }

      .empty-box {
        text-align: center;
      }

      i {
        background-size: contain;
        height: var(--icons-size, 50px);
        width: var(--icons-size, 50px);
        display: inline-block;
      }

      i.reload {
        background-image: url("${new URL('./reload.svg', import.meta.url).toString()}");
      }
    `;

    shadowRoot.appendChild(style);

    this.container = document.createElement('div');
    this.container.classList.add('cards-stack');
    shadowRoot.appendChild(this.container);

    /**
     * the deck of cards currently rendered
     * @private
     * @type {Array.<Card>}
     */
    this.currentDeck = null;

    /**
     * @private
     */
    this._collection = null;

    this.emptyStackEvent = new CustomEvent('empty-stack', {
      bubbles: false,
      cancelable: false,
      composed: true
    });

    this.reloadFromCollectionEvent = new CustomEvent('reload-collection', {
      bubbles: false,
      cancelable: false,
      composed: true
    });

    this.renderNoCollection();
  }

  /**
   * **Immutable** collection of cards
   * Updating this property will cause this component to render **all** its content.
   * Do so **only** if you need to load an entire new collection of cards!
   * @type {Array.<Cards>}
   */
  set collection(collection) {
    this.propertyChangedCallback('collection', this._collection, collection);
  }

  /**
   * @type {Array.<Cards>}
   */
  get collection() {
    return this._collection;
  }

  /**
   * remove the last (top) card from the deck
   * @returns  {{card: Card, element: HTMLElement}} - removed card object and the corresponsing HTMLElement
   */
  pop() {
    const lastCard = this.currentDeck[this.currentDeck.length - 1];
    this.currentDeck = this.currentDeck.slice(0, -1);
    const lastCardElmt = this.container.lastElementChild;
    this.container.removeChild(lastCardElmt);
    if (this.currentDeck.length <= 0) {
      this.dispatchEvent(this.emptyStackEvent);
      this.renderEmptyMsg();
    }
    return { card: lastCard, element: lastCardElmt };
  }

  renderEmptyMsg() {
    const emptyBox = document.createElement('div');
    emptyBox.classList.add('empty-box');
    emptyBox.innerHTML = html`
      <p>You finished this session! Click the reload button to review this collection again.</p>
      <i class="reload"></i>
    `;
    emptyBox.querySelector('.reload').addEventListener('click', () => {
      this.render(this._collection);
      this.dispatchEvent(this.reloadFromCollectionEvent);
    });
    this.container.appendChild(emptyBox);
  }

  renderNoCollection() {
    this.container.innerHTML = `<p>No valid collection</p>`;
  }

  /**
   *
   */
  moveBack() {
    const lastCard = this.currentDeck[this.currentDeck.length - 1];
    this.currentDeck = [lastCard, ...this.currentDeck.slice(0, -1)];
    const elmt = this.container.lastElementChild;
    this.container.prepend(elmt);
    elmt.firstElementChild.removeAttribute('flipped');
  }

  /**
   * @private
   * @param {*} prop
   * @param {*} oldValue
   * @param {*} newValue
   */
  propertyChangedCallback(prop, oldValue, newValue) {
    // cards collections are considered immutable
    if (prop === 'collection' && oldValue !== newValue) {
      if(Array.isArray(newValue) && newValue.length > 0) {
        this.render([...newValue]);
        this._collection = newValue;
      } else {
        this.renderNoCollection();
        this._collection = null;
        this.currentDeck = null;
      }
    }
  }

  render(cards) {
    if (!this.currentDeck || cards.length !== this.currentDeck.length) {
      this.container.style.paddingTop = `${cards.length * 5}px`;
    }
    this.container.innerHTML = cards
      .map(
        card => `
          <div class="card-wrapper">
            ${cardHtml(card)}
          </div>
        `
      )
      .join('');
    this.currentDeck = cards;
  }
}

customElements.define('dc-stack', CardStackComponent);

Using karma-jasmine, I get exactly the same file in the browser, except the link to the source-map is added at the end. But with Mocha, I get:

transformed by Mocha/Chai
var cov_cpzqxydh8 = function () {
  var path = "/home/noel/git/web-on-fire/flashcards-app/src/components/card-stack/card-stack.js";
  var hash = "ee059f4e606dadd64733046accbba36270bd5104";
  var global = new Function("return this")();
  var gcv = "__coverage__";
  var coverageData = {
    path: "/home/noel/git/web-on-fire/flashcards-app/src/components/card-stack/card-stack.js",
    statementMap: {
      "0": {
        start: {
          line: 9,
          column: 4
        },
        end: {
          line: 9,
          column: 12
        }
      },
      "1": {
        start: {
          line: 11,
          column: 23
        },
        end: {
          line: 11,
          column: 58
        }
      },
      "2": {
        start: {
          line: 13,
          column: 18
        },
        end: {
          line: 13,
          column: 49
        }
      },
      "3": {
        start: {
          line: 15,
          column: 4
        },
        end: {
          line: 45,
          column: 6
        }
      },
      "4": {
        start: {
          line: 47,
          column: 4
        },
        end: {
          line: 47,
          column: 34
        }
      },
      "5": {
        start: {
          line: 49,
          column: 4
        },
        end: {
          line: 49,
          column: 51
        }
      },
      "6": {
        start: {
          line: 50,
          column: 4
        },
        end: {
          line: 50,
          column: 48
        }
      },
      "7": {
        start: {
          line: 51,
          column: 4
        },
        end: {
          line: 51,
          column: 43
        }
      },
      "8": {
        start: {
          line: 58,
          column: 4
        },
        end: {
          line: 58,
          column: 28
        }
      },
      "9": {
        start: {
          line: 63,
          column: 4
        },
        end: {
          line: 63,
          column: 28
        }
      },
      "10": {
        start: {
          line: 65,
          column: 4
        },
        end: {
          line: 69,
          column: 7
        }
      },
      "11": {
        start: {
          line: 71,
          column: 4
        },
        end: {
          line: 75,
          column: 7
        }
      },
      "12": {
        start: {
          line: 77,
          column: 4
        },
        end: {
          line: 77,
          column: 30
        }
      },
      "13": {
        start: {
          line: 87,
          column: 4
        },
        end: {
          line: 87,
          column: 77
        }
      },
      "14": {
        start: {
          line: 94,
          column: 4
        },
        end: {
          line: 94,
          column: 28
        }
      },
      "15": {
        start: {
          line: 102,
          column: 21
        },
        end: {
          line: 102,
          column: 66
        }
      },
      "16": {
        start: {
          line: 103,
          column: 4
        },
        end: {
          line: 103,
          column: 53
        }
      },
      "17": {
        start: {
          line: 104,
          column: 25
        },
        end: {
          line: 104,
          column: 56
        }
      },
      "18": {
        start: {
          line: 105,
          column: 4
        },
        end: {
          line: 105,
          column: 45
        }
      },
      "19": {
        start: {
          line: 106,
          column: 4
        },
        end: {
          line: 109,
          column: 5
        }
      },
      "20": {
        start: {
          line: 107,
          column: 6
        },
        end: {
          line: 107,
          column: 47
        }
      },
      "21": {
        start: {
          line: 108,
          column: 6
        },
        end: {
          line: 108,
          column: 28
        }
      },
      "22": {
        start: {
          line: 110,
          column: 4
        },
        end: {
          line: 110,
          column: 53
        }
      },
      "23": {
        start: {
          line: 114,
          column: 21
        },
        end: {
          line: 114,
          column: 50
        }
      },
      "24": {
        start: {
          line: 115,
          column: 4
        },
        end: {
          line: 115,
          column: 40
        }
      },
      "25": {
        start: {
          line: 116,
          column: 4
        },
        end: {
          line: 119,
          column: 6
        }
      },
      "26": {
        start: {
          line: 120,
          column: 4
        },
        end: {
          line: 123,
          column: 7
        }
      },
      "27": {
        start: {
          line: 121,
          column: 6
        },
        end: {
          line: 121,
          column: 36
        }
      },
      "28": {
        start: {
          line: 122,
          column: 6
        },
        end: {
          line: 122,
          column: 57
        }
      },
      "29": {
        start: {
          line: 124,
          column: 4
        },
        end: {
          line: 124,
          column: 41
        }
      },
      "30": {
        start: {
          line: 128,
          column: 4
        },
        end: {
          line: 128,
          column: 60
        }
      },
      "31": {
        start: {
          line: 135,
          column: 21
        },
        end: {
          line: 135,
          column: 66
        }
      },
      "32": {
        start: {
          line: 136,
          column: 4
        },
        end: {
          line: 136,
          column: 68
        }
      },
      "33": {
        start: {
          line: 137,
          column: 17
        },
        end: {
          line: 137,
          column: 48
        }
      },
      "34": {
        start: {
          line: 138,
          column: 4
        },
        end: {
          line: 138,
          column: 33
        }
      },
      "35": {
        start: {
          line: 139,
          column: 4
        },
        end: {
          line: 139,
          column: 54
        }
      },
      "36": {
        start: {
          line: 150,
          column: 4
        },
        end: {
          line: 159,
          column: 5
        }
      },
      "37": {
        start: {
          line: 151,
          column: 6
        },
        end: {
          line: 158,
          column: 7
        }
      },
      "38": {
        start: {
          line: 152,
          column: 8
        },
        end: {
          line: 152,
          column: 35
        }
      },
      "39": {
        start: {
          line: 153,
          column: 8
        },
        end: {
          line: 153,
          column: 36
        }
      },
      "40": {
        start: {
          line: 155,
          column: 8
        },
        end: {
          line: 155,
          column: 34
        }
      },
      "41": {
        start: {
          line: 156,
          column: 8
        },
        end: {
          line: 156,
          column: 32
        }
      },
      "42": {
        start: {
          line: 157,
          column: 8
        },
        end: {
          line: 157,
          column: 32
        }
      },
      "43": {
        start: {
          line: 163,
          column: 4
        },
        end: {
          line: 165,
          column: 5
        }
      },
      "44": {
        start: {
          line: 164,
          column: 6
        },
        end: {
          line: 164,
          column: 64
        }
      },
      "45": {
        start: {
          line: 166,
          column: 4
        },
        end: {
          line: 174,
          column: 16
        }
      },
      "46": {
        start: {
          line: 168,
          column: 16
        },
        end: {
          line: 172,
          column: 9
        }
      },
      "47": {
        start: {
          line: 175,
          column: 4
        },
        end: {
          line: 175,
          column: 29
        }
      },
      "48": {
        start: {
          line: 179,
          column: 0
        },
        end: {
          line: 179,
          column: 54
        }
      }
    },
    fnMap: {
      "0": {
        name: "(anonymous_0)",
        decl: {
          start: {
            line: 8,
            column: 2
          },
          end: {
            line: 8,
            column: 3
          }
        },
        loc: {
          start: {
            line: 8,
            column: 16
          },
          end: {
            line: 78,
            column: 3
          }
        },
        line: 8
      },
      "1": {
        name: "(anonymous_1)",
        decl: {
          start: {
            line: 86,
            column: 2
          },
          end: {
            line: 86,
            column: 3
          }
        },
        loc: {
          start: {
            line: 86,
            column: 29
          },
          end: {
            line: 88,
            column: 3
          }
        },
        line: 86
      },
      "2": {
        name: "(anonymous_2)",
        decl: {
          start: {
            line: 93,
            column: 2
          },
          end: {
            line: 93,
            column: 3
          }
        },
        loc: {
          start: {
            line: 93,
            column: 19
          },
          end: {
            line: 95,
            column: 3
          }
        },
        line: 93
      },
      "3": {
        name: "(anonymous_3)",
        decl: {
          start: {
            line: 101,
            column: 2
          },
          end: {
            line: 101,
            column: 3
          }
        },
        loc: {
          start: {
            line: 101,
            column: 8
          },
          end: {
            line: 111,
            column: 3
          }
        },
        line: 101
      },
      "4": {
        name: "(anonymous_4)",
        decl: {
          start: {
            line: 113,
            column: 2
          },
          end: {
            line: 113,
            column: 3
          }
        },
        loc: {
          start: {
            line: 113,
            column: 19
          },
          end: {
            line: 125,
            column: 3
          }
        },
        line: 113
      },
      "5": {
        name: "(anonymous_5)",
        decl: {
          start: {
            line: 120,
            column: 64
          },
          end: {
            line: 120,
            column: 65
          }
        },
        loc: {
          start: {
            line: 120,
            column: 70
          },
          end: {
            line: 123,
            column: 5
          }
        },
        line: 120
      },
      "6": {
        name: "(anonymous_6)",
        decl: {
          start: {
            line: 127,
            column: 2
          },
          end: {
            line: 127,
            column: 3
          }
        },
        loc: {
          start: {
            line: 127,
            column: 23
          },
          end: {
            line: 129,
            column: 3
          }
        },
        line: 127
      },
      "7": {
        name: "(anonymous_7)",
        decl: {
          start: {
            line: 134,
            column: 2
          },
          end: {
            line: 134,
            column: 3
          }
        },
        loc: {
          start: {
            line: 134,
            column: 13
          },
          end: {
            line: 140,
            column: 3
          }
        },
        line: 134
      },
      "8": {
        name: "(anonymous_8)",
        decl: {
          start: {
            line: 148,
            column: 2
          },
          end: {
            line: 148,
            column: 3
          }
        },
        loc: {
          start: {
            line: 148,
            column: 52
          },
          end: {
            line: 160,
            column: 3
          }
        },
        line: 148
      },
      "9": {
        name: "(anonymous_9)",
        decl: {
          start: {
            line: 162,
            column: 2
          },
          end: {
            line: 162,
            column: 3
          }
        },
        loc: {
          start: {
            line: 162,
            column: 16
          },
          end: {
            line: 176,
            column: 3
          }
        },
        line: 162
      },
      "10": {
        name: "(anonymous_10)",
        decl: {
          start: {
            line: 168,
            column: 8
          },
          end: {
            line: 168,
            column: 9
          }
        },
        loc: {
          start: {
            line: 168,
            column: 16
          },
          end: {
            line: 172,
            column: 9
          }
        },
        line: 168
      }
    },
    branchMap: {
      "0": {
        loc: {
          start: {
            line: 106,
            column: 4
          },
          end: {
            line: 109,
            column: 5
          }
        },
        type: "if",
        locations: [{
          start: {
            line: 106,
            column: 4
          },
          end: {
            line: 109,
            column: 5
          }
        }, {
          start: {
            line: 106,
            column: 4
          },
          end: {
            line: 109,
            column: 5
          }
        }],
        line: 106
      },
      "1": {
        loc: {
          start: {
            line: 150,
            column: 4
          },
          end: {
            line: 159,
            column: 5
          }
        },
        type: "if",
        locations: [{
          start: {
            line: 150,
            column: 4
          },
          end: {
            line: 159,
            column: 5
          }
        }, {
          start: {
            line: 150,
            column: 4
          },
          end: {
            line: 159,
            column: 5
          }
        }],
        line: 150
      },
      "2": {
        loc: {
          start: {
            line: 150,
            column: 8
          },
          end: {
            line: 150,
            column: 54
          }
        },
        type: "binary-expr",
        locations: [{
          start: {
            line: 150,
            column: 8
          },
          end: {
            line: 150,
            column: 29
          }
        }, {
          start: {
            line: 150,
            column: 33
          },
          end: {
            line: 150,
            column: 54
          }
        }],
        line: 150
      },
      "3": {
        loc: {
          start: {
            line: 151,
            column: 6
          },
          end: {
            line: 158,
            column: 7
          }
        },
        type: "if",
        locations: [{
          start: {
            line: 151,
            column: 6
          },
          end: {
            line: 158,
            column: 7
          }
        }, {
          start: {
            line: 151,
            column: 6
          },
          end: {
            line: 158,
            column: 7
          }
        }],
        line: 151
      },
      "4": {
        loc: {
          start: {
            line: 151,
            column: 9
          },
          end: {
            line: 151,
            column: 55
          }
        },
        type: "binary-expr",
        locations: [{
          start: {
            line: 151,
            column: 9
          },
          end: {
            line: 151,
            column: 32
          }
        }, {
          start: {
            line: 151,
            column: 36
          },
          end: {
            line: 151,
            column: 55
          }
        }],
        line: 151
      },
      "5": {
        loc: {
          start: {
            line: 163,
            column: 4
          },
          end: {
            line: 165,
            column: 5
          }
        },
        type: "if",
        locations: [{
          start: {
            line: 163,
            column: 4
          },
          end: {
            line: 165,
            column: 5
          }
        }, {
          start: {
            line: 163,
            column: 4
          },
          end: {
            line: 165,
            column: 5
          }
        }],
        line: 163
      },
      "6": {
        loc: {
          start: {
            line: 163,
            column: 8
          },
          end: {
            line: 163,
            column: 69
          }
        },
        type: "binary-expr",
        locations: [{
          start: {
            line: 163,
            column: 8
          },
          end: {
            line: 163,
            column: 25
          }
        }, {
          start: {
            line: 163,
            column: 29
          },
          end: {
            line: 163,
            column: 69
          }
        }],
        line: 163
      }
    },
    s: {
      "0": 0,
      "1": 0,
      "2": 0,
      "3": 0,
      "4": 0,
      "5": 0,
      "6": 0,
      "7": 0,
      "8": 0,
      "9": 0,
      "10": 0,
      "11": 0,
      "12": 0,
      "13": 0,
      "14": 0,
      "15": 0,
      "16": 0,
      "17": 0,
      "18": 0,
      "19": 0,
      "20": 0,
      "21": 0,
      "22": 0,
      "23": 0,
      "24": 0,
      "25": 0,
      "26": 0,
      "27": 0,
      "28": 0,
      "29": 0,
      "30": 0,
      "31": 0,
      "32": 0,
      "33": 0,
      "34": 0,
      "35": 0,
      "36": 0,
      "37": 0,
      "38": 0,
      "39": 0,
      "40": 0,
      "41": 0,
      "42": 0,
      "43": 0,
      "44": 0,
      "45": 0,
      "46": 0,
      "47": 0,
      "48": 0
    },
    f: {
      "0": 0,
      "1": 0,
      "2": 0,
      "3": 0,
      "4": 0,
      "5": 0,
      "6": 0,
      "7": 0,
      "8": 0,
      "9": 0,
      "10": 0
    },
    b: {
      "0": [0, 0],
      "1": [0, 0],
      "2": [0, 0],
      "3": [0, 0],
      "4": [0, 0],
      "5": [0, 0],
      "6": [0, 0]
    },
    _coverageSchema: "43e27e138ebf9cfc5966b082cf9a028302ed4184",
    hash: "ee059f4e606dadd64733046accbba36270bd5104"
  };
  var coverage = global[gcv] || (global[gcv] = {});

  if (coverage[path] && coverage[path].hash === hash) {
    return coverage[path];
  }

  return coverage[path] = coverageData;
}();

import { css, html } from "../../utils/tags.js";
import { cardHtml } from "../flashcard/flashcard.js";
/**
 * Web Component representing a stacked flashcard deck
 */

class CardStackComponent extends HTMLElement {
  constructor() {
    cov_cpzqxydh8.f[0]++;
    cov_cpzqxydh8.s[0]++;
    super();
    const shadowRoot = (cov_cpzqxydh8.s[1]++, this.attachShadow({
      mode: 'open'
    }));
    const style = (cov_cpzqxydh8.s[2]++, document.createElement('style'));
    cov_cpzqxydh8.s[3]++;
    style.innerText = css`
      .card-wrapper {
        height: 0;
        margin-top: -5px;
      }

      .cards-stack {
        height: calc(var(--card-width) * 1.39);
      }

      dc-flashcard {
        height: 500px;
        width: 300px;
        overflow: scroll;
      }

      .empty-box {
        text-align: center;
      }

      i {
        background-size: contain;
        height: var(--icons-size, 50px);
        width: var(--icons-size, 50px);
        display: inline-block;
      }

      i.reload {
        background-image: url("${new URL('./reload.svg', import.meta.url).toString()}");
      }
    `;
    cov_cpzqxydh8.s[4]++;
    shadowRoot.appendChild(style);
    cov_cpzqxydh8.s[5]++;
    this.container = document.createElement('div');
    cov_cpzqxydh8.s[6]++;
    this.container.classList.add('cards-stack');
    cov_cpzqxydh8.s[7]++;
    shadowRoot.appendChild(this.container);
    /**
     * the deck of cards currently rendered
     * @private
     * @type {Array.<Card>}
     */

    cov_cpzqxydh8.s[8]++;
    this.currentDeck = null;
    /**
     * @private
     */

    cov_cpzqxydh8.s[9]++;
    this._collection = null;
    cov_cpzqxydh8.s[10]++;
    this.emptyStackEvent = new CustomEvent('empty-stack', {
      bubbles: false,
      cancelable: false,
      composed: true
    });
    cov_cpzqxydh8.s[11]++;
    this.reloadFromCollectionEvent = new CustomEvent('reload-collection', {
      bubbles: false,
      cancelable: false,
      composed: true
    });
    cov_cpzqxydh8.s[12]++;
    this.renderNoCollection();
  }
  /**
   * **Immutable** collection of cards
   * Updating this property will cause this component to render **all** its content.
   * Do so **only** if you need to load an entire new collection of cards!
   * @type {Array.<Cards>}
   */


  set collection(collection) {
    cov_cpzqxydh8.f[1]++;
    cov_cpzqxydh8.s[13]++;
    this.propertyChangedCallback('collection', this._collection, collection);
  }
  /**
   * @type {Array.<Cards>}
   */


  get collection() {
    cov_cpzqxydh8.f[2]++;
    cov_cpzqxydh8.s[14]++;
    return this._collection;
  }
  /**
   * remove the last (top) card from the deck
   * @returns  {{card: Card, element: HTMLElement}} - removed card object and the corresponsing HTMLElement
   */


  pop() {
    cov_cpzqxydh8.f[3]++;
    const lastCard = (cov_cpzqxydh8.s[15]++, this.currentDeck[this.currentDeck.length - 1]);
    cov_cpzqxydh8.s[16]++;
    this.currentDeck = this.currentDeck.slice(0, -1);
    const lastCardElmt = (cov_cpzqxydh8.s[17]++, this.container.lastElementChild);
    cov_cpzqxydh8.s[18]++;
    this.container.removeChild(lastCardElmt);
    cov_cpzqxydh8.s[19]++;

    if (this.currentDeck.length <= 0) {
      cov_cpzqxydh8.b[0][0]++;
      cov_cpzqxydh8.s[20]++;
      this.dispatchEvent(this.emptyStackEvent);
      cov_cpzqxydh8.s[21]++;
      this.renderEmptyMsg();
    } else {
      cov_cpzqxydh8.b[0][1]++;
    }

    cov_cpzqxydh8.s[22]++;
    return {
      card: lastCard,
      element: lastCardElmt
    };
  }

  renderEmptyMsg() {
    cov_cpzqxydh8.f[4]++;
    const emptyBox = (cov_cpzqxydh8.s[23]++, document.createElement('div'));
    cov_cpzqxydh8.s[24]++;
    emptyBox.classList.add('empty-box');
    cov_cpzqxydh8.s[25]++;
    emptyBox.innerHTML = html`
      <p>You finished this session! Click the reload button to review this collection again.</p>
      <i class="reload"></i>
    `;
    cov_cpzqxydh8.s[26]++;
    emptyBox.querySelector('.reload').addEventListener('click', () => {
      cov_cpzqxydh8.f[5]++;
      cov_cpzqxydh8.s[27]++;
      this.render(this._collection);
      cov_cpzqxydh8.s[28]++;
      this.dispatchEvent(this.reloadFromCollectionEvent);
    });
    cov_cpzqxydh8.s[29]++;
    this.container.appendChild(emptyBox);
  }

  renderNoCollection() {
    cov_cpzqxydh8.f[6]++;
    cov_cpzqxydh8.s[30]++;
    this.container.innerHTML = `<p>No valid collection</p>`;
  }
  /**
   *
   */


  moveBack() {
    cov_cpzqxydh8.f[7]++;
    const lastCard = (cov_cpzqxydh8.s[31]++, this.currentDeck[this.currentDeck.length - 1]);
    cov_cpzqxydh8.s[32]++;
    this.currentDeck = [lastCard, ...this.currentDeck.slice(0, -1)];
    const elmt = (cov_cpzqxydh8.s[33]++, this.container.lastElementChild);
    cov_cpzqxydh8.s[34]++;
    this.container.prepend(elmt);
    cov_cpzqxydh8.s[35]++;
    elmt.firstElementChild.removeAttribute('flipped');
  }
  /**
   * @private
   * @param {*} prop
   * @param {*} oldValue
   * @param {*} newValue
   */


  propertyChangedCallback(prop, oldValue, newValue) {
    cov_cpzqxydh8.f[8]++;
    cov_cpzqxydh8.s[36]++;

    // cards collections are considered immutable
    if ((cov_cpzqxydh8.b[2][0]++, prop === 'collection') && (cov_cpzqxydh8.b[2][1]++, oldValue !== newValue)) {
      cov_cpzqxydh8.b[1][0]++;
      cov_cpzqxydh8.s[37]++;

      if ((cov_cpzqxydh8.b[4][0]++, Array.isArray(newValue)) && (cov_cpzqxydh8.b[4][1]++, newValue.length > 0)) {
        cov_cpzqxydh8.b[3][0]++;
        cov_cpzqxydh8.s[38]++;
        this.render([...newValue]);
        cov_cpzqxydh8.s[39]++;
        this._collection = newValue;
      } else {
        cov_cpzqxydh8.b[3][1]++;
        cov_cpzqxydh8.s[40]++;
        this.renderNoCollection();
        cov_cpzqxydh8.s[41]++;
        this._collection = null;
        cov_cpzqxydh8.s[42]++;
        this.currentDeck = null;
      }
    } else {
      cov_cpzqxydh8.b[1][1]++;
    }
  }

  render(cards) {
    cov_cpzqxydh8.f[9]++;
    cov_cpzqxydh8.s[43]++;

    if ((cov_cpzqxydh8.b[6][0]++, !this.currentDeck) || (cov_cpzqxydh8.b[6][1]++, cards.length !== this.currentDeck.length)) {
      cov_cpzqxydh8.b[5][0]++;
      cov_cpzqxydh8.s[44]++;
      this.container.style.paddingTop = `${cards.length * 5}px`;
    } else {
      cov_cpzqxydh8.b[5][1]++;
    }

    cov_cpzqxydh8.s[45]++;
    this.container.innerHTML = cards.map(card => {
      cov_cpzqxydh8.f[10]++;
      cov_cpzqxydh8.s[46]++;
      return `
          <div class="card-wrapper">
            ${cardHtml(card)}
          </div>
        `;
    }).join('');
    cov_cpzqxydh8.s[47]++;
    this.currentDeck = cards;
  }

}

cov_cpzqxydh8.s[48]++;
customElements.define('dc-stack', CardStackComponent);
//# sourceMappingURL=data:application/json;charset=utf-8;base64,{"version":3,"sources":["card-stack.js"],"names":["css","html","cardHtml","CardStackComponent","HTMLElement","constructor","shadowRoot","attachShadow","mode","style","document","createElement","innerText","URL","import","meta","url","toString","appendChild","container","classList","add","currentDeck","_collection","emptyStackEvent","CustomEvent","bubbles","cancelable","composed","reloadFromCollectionEvent","renderNoCollection","collection","propertyChangedCallback","pop","lastCard","length","slice","lastCardElmt","lastElementChild","removeChild","dispatchEvent","renderEmptyMsg","card","element","emptyBox","innerHTML","querySelector","addEventListener","render","moveBack","elmt","prepend","firstElementChild","removeAttribute","prop","oldValue","newValue","Array","isArray","cards","paddingTop","map","join","customElements","define"],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAAA,SAASA,GAAT,EAAcC,IAAd;AACA,SAASC,QAAT;AAEA;;;;AAGA,MAAMC,kBAAN,SAAiCC,WAAjC,CAA6C;AAC3CC,EAAAA,WAAW,GAAG;AAAA;AAAA;AACZ;AAEA,UAAMC,UAAU,0BAAG,KAAKC,YAAL,CAAkB;AAAEC,MAAAA,IAAI,EAAE;AAAR,KAAlB,CAAH,CAAhB;AAEA,UAAMC,KAAK,0BAAGC,QAAQ,CAACC,aAAT,CAAuB,OAAvB,CAAH,CAAX;AALY;AAOZF,IAAAA,KAAK,CAACG,SAAN,GAAkBZ,GAAI;;;;;;;;;;;;;;;;;;;;;;;;;;;;iCA4BO,IAAIa,GAAJ,CAAQ,cAAR,EAAwBC,MAAM,CAACC,IAAP,CAAYC,GAApC,EAAyCC,QAAzC,EAAoD;;KA5BjF;AAPY;AAuCZX,IAAAA,UAAU,CAACY,WAAX,CAAuBT,KAAvB;AAvCY;AAyCZ,SAAKU,SAAL,GAAiBT,QAAQ,CAACC,aAAT,CAAuB,KAAvB,CAAjB;AAzCY;AA0CZ,SAAKQ,SAAL,CAAeC,SAAf,CAAyBC,GAAzB,CAA6B,aAA7B;AA1CY;AA2CZf,IAAAA,UAAU,CAACY,WAAX,CAAuB,KAAKC,SAA5B;AAEA;;;;;;AA7CY;AAkDZ,SAAKG,WAAL,GAAmB,IAAnB;AAEA;;;;AApDY;AAuDZ,SAAKC,WAAL,GAAmB,IAAnB;AAvDY;AAyDZ,SAAKC,eAAL,GAAuB,IAAIC,WAAJ,CAAgB,aAAhB,EAA+B;AACpDC,MAAAA,OAAO,EAAE,KAD2C;AAEpDC,MAAAA,UAAU,EAAE,KAFwC;AAGpDC,MAAAA,QAAQ,EAAE;AAH0C,KAA/B,CAAvB;AAzDY;AA+DZ,SAAKC,yBAAL,GAAiC,IAAIJ,WAAJ,CAAgB,mBAAhB,EAAqC;AACpEC,MAAAA,OAAO,EAAE,KAD2D;AAEpEC,MAAAA,UAAU,EAAE,KAFwD;AAGpEC,MAAAA,QAAQ,EAAE;AAH0D,KAArC,CAAjC;AA/DY;AAqEZ,SAAKE,kBAAL;AACD;AAED;;;;;;;;AAMA,MAAIC,UAAJ,CAAeA,UAAf,EAA2B;AAAA;AAAA;AACzB,SAAKC,uBAAL,CAA6B,YAA7B,EAA2C,KAAKT,WAAhD,EAA6DQ,UAA7D;AACD;AAED;;;;;AAGA,MAAIA,UAAJ,GAAiB;AAAA;AAAA;AACf,WAAO,KAAKR,WAAZ;AACD;AAED;;;;;;AAIAU,EAAAA,GAAG,GAAG;AAAA;AACJ,UAAMC,QAAQ,2BAAG,KAAKZ,WAAL,CAAiB,KAAKA,WAAL,CAAiBa,MAAjB,GAA0B,CAA3C,CAAH,CAAd;AADI;AAEJ,SAAKb,WAAL,GAAmB,KAAKA,WAAL,CAAiBc,KAAjB,CAAuB,CAAvB,EAA0B,CAAC,CAA3B,CAAnB;AACA,UAAMC,YAAY,2BAAG,KAAKlB,SAAL,CAAemB,gBAAlB,CAAlB;AAHI;AAIJ,SAAKnB,SAAL,CAAeoB,WAAf,CAA2BF,YAA3B;AAJI;;AAKJ,QAAI,KAAKf,WAAL,CAAiBa,MAAjB,IAA2B,CAA/B,EAAkC;AAAA;AAAA;AAChC,WAAKK,aAAL,CAAmB,KAAKhB,eAAxB;AADgC;AAEhC,WAAKiB,cAAL;AACD,KAHD;AAAA;AAAA;;AALI;AASJ,WAAO;AAAEC,MAAAA,IAAI,EAAER,QAAR;AAAkBS,MAAAA,OAAO,EAAEN;AAA3B,KAAP;AACD;;AAEDI,EAAAA,cAAc,GAAG;AAAA;AACf,UAAMG,QAAQ,2BAAGlC,QAAQ,CAACC,aAAT,CAAuB,KAAvB,CAAH,CAAd;AADe;AAEfiC,IAAAA,QAAQ,CAACxB,SAAT,CAAmBC,GAAnB,CAAuB,WAAvB;AAFe;AAGfuB,IAAAA,QAAQ,CAACC,SAAT,GAAqB5C,IAAK;;;KAA1B;AAHe;AAOf2C,IAAAA,QAAQ,CAACE,aAAT,CAAuB,SAAvB,EAAkCC,gBAAlC,CAAmD,OAAnD,EAA4D,MAAM;AAAA;AAAA;AAChE,WAAKC,MAAL,CAAY,KAAKzB,WAAjB;AADgE;AAEhE,WAAKiB,aAAL,CAAmB,KAAKX,yBAAxB;AACD,KAHD;AAPe;AAWf,SAAKV,SAAL,CAAeD,WAAf,CAA2B0B,QAA3B;AACD;;AAEDd,EAAAA,kBAAkB,GAAG;AAAA;AAAA;AACnB,SAAKX,SAAL,CAAe0B,SAAf,GAA4B,4BAA5B;AACD;AAED;;;;;AAGAI,EAAAA,QAAQ,GAAG;AAAA;AACT,UAAMf,QAAQ,2BAAG,KAAKZ,WAAL,CAAiB,KAAKA,WAAL,CAAiBa,MAAjB,GAA0B,CAA3C,CAAH,CAAd;AADS;AAET,SAAKb,WAAL,GAAmB,CAACY,QAAD,EAAW,GAAG,KAAKZ,WAAL,CAAiBc,KAAjB,CAAuB,CAAvB,EAA0B,CAAC,CAA3B,CAAd,CAAnB;AACA,UAAMc,IAAI,2BAAG,KAAK/B,SAAL,CAAemB,gBAAlB,CAAV;AAHS;AAIT,SAAKnB,SAAL,CAAegC,OAAf,CAAuBD,IAAvB;AAJS;AAKTA,IAAAA,IAAI,CAACE,iBAAL,CAAuBC,eAAvB,CAAuC,SAAvC;AACD;AAED;;;;;;;;AAMArB,EAAAA,uBAAuB,CAACsB,IAAD,EAAOC,QAAP,EAAiBC,QAAjB,EAA2B;AAAA;AAAA;;AAChD;AACA,QAAI,0BAAAF,IAAI,KAAK,YAAT,+BAAyBC,QAAQ,KAAKC,QAAtC,CAAJ,EAAoD;AAAA;AAAA;;AAClD,UAAG,0BAAAC,KAAK,CAACC,OAAN,CAAcF,QAAd,gCAA2BA,QAAQ,CAACrB,MAAT,GAAkB,CAA7C,CAAH,EAAmD;AAAA;AAAA;AACjD,aAAKa,MAAL,CAAY,CAAC,GAAGQ,QAAJ,CAAZ;AADiD;AAEjD,aAAKjC,WAAL,GAAmBiC,QAAnB;AACD,OAHD,MAGO;AAAA;AAAA;AACL,aAAK1B,kBAAL;AADK;AAEL,aAAKP,WAAL,GAAmB,IAAnB;AAFK;AAGL,aAAKD,WAAL,GAAmB,IAAnB;AACD;AACF,KATD;AAAA;AAAA;AAUD;;AAED0B,EAAAA,MAAM,CAACW,KAAD,EAAQ;AAAA;AAAA;;AACZ,QAAI,2BAAC,KAAKrC,WAAN,+BAAqBqC,KAAK,CAACxB,MAAN,KAAiB,KAAKb,WAAL,CAAiBa,MAAvD,CAAJ,EAAmE;AAAA;AAAA;AACjE,WAAKhB,SAAL,CAAeV,KAAf,CAAqBmD,UAArB,GAAmC,GAAED,KAAK,CAACxB,MAAN,GAAe,CAAE,IAAtD;AACD,KAFD;AAAA;AAAA;;AADY;AAIZ,SAAKhB,SAAL,CAAe0B,SAAf,GAA2Bc,KAAK,CAC7BE,GADwB,CAEvBnB,IAAI,IAAI;AAAA;AAAA;AAAA,aAAC;;cAEHxC,QAAQ,CAACwC,IAAD,CAAO;;SAFb;AAIP,KANsB,EAQxBoB,IARwB,CAQnB,EARmB,CAA3B;AAJY;AAaZ,SAAKxC,WAAL,GAAmBqC,KAAnB;AACD;;AAzK0C;;;AA4K7CI,cAAc,CAACC,MAAf,CAAsB,UAAtB,EAAkC7D,kBAAlC","sourcesContent":["import { css, html } from '../../utils/tags.js';\nimport { cardHtml } from '../flashcard/flashcard.js';\n\n/**\n * Web Component representing a stacked flashcard deck\n */\nclass CardStackComponent extends HTMLElement {\n  constructor() {\n    super();\n\n    const shadowRoot = this.attachShadow({ mode: 'open' });\n\n    const style = document.createElement('style');\n\n    style.innerText = css`\n      .card-wrapper {\n        height: 0;\n        margin-top: -5px;\n      }\n\n      .cards-stack {\n        height: calc(var(--card-width) * 1.39);\n      }\n\n      dc-flashcard {\n        height: 500px;\n        width: 300px;\n        overflow: scroll;\n      }\n\n      .empty-box {\n        text-align: center;\n      }\n\n      i {\n        background-size: contain;\n        height: var(--icons-size, 50px);\n        width: var(--icons-size, 50px);\n        display: inline-block;\n      }\n\n      i.reload {\n        background-image: url(\"${new URL('./reload.svg', import.meta.url).toString()}\");\n      }\n    `;\n\n    shadowRoot.appendChild(style);\n\n    this.container = document.createElement('div');\n    this.container.classList.add('cards-stack');\n    shadowRoot.appendChild(this.container);\n\n    /**\n     * the deck of cards currently rendered\n     * @private\n     * @type {Array.<Card>}\n     */\n    this.currentDeck = null;\n\n    /**\n     * @private\n     */\n    this._collection = null;\n\n    this.emptyStackEvent = new CustomEvent('empty-stack', {\n      bubbles: false,\n      cancelable: false,\n      composed: true\n    });\n\n    this.reloadFromCollectionEvent = new CustomEvent('reload-collection', {\n      bubbles: false,\n      cancelable: false,\n      composed: true\n    });\n\n    this.renderNoCollection();\n  }\n\n  /**\n   * **Immutable** collection of cards\n   * Updating this property will cause this component to render **all** its content.\n   * Do so **only** if you need to load an entire new collection of cards!\n   * @type {Array.<Cards>}\n   */\n  set collection(collection) {\n    this.propertyChangedCallback('collection', this._collection, collection);\n  }\n\n  /**\n   * @type {Array.<Cards>}\n   */\n  get collection() {\n    return this._collection;\n  }\n\n  /**\n   * remove the last (top) card from the deck\n   * @returns  {{card: Card, element: HTMLElement}} - removed card object and the corresponsing HTMLElement\n   */\n  pop() {\n    const lastCard = this.currentDeck[this.currentDeck.length - 1];\n    this.currentDeck = this.currentDeck.slice(0, -1);\n    const lastCardElmt = this.container.lastElementChild;\n    this.container.removeChild(lastCardElmt);\n    if (this.currentDeck.length <= 0) {\n      this.dispatchEvent(this.emptyStackEvent);\n      this.renderEmptyMsg();\n    }\n    return { card: lastCard, element: lastCardElmt };\n  }\n\n  renderEmptyMsg() {\n    const emptyBox = document.createElement('div');\n    emptyBox.classList.add('empty-box');\n    emptyBox.innerHTML = html`\n      <p>You finished this session! Click the reload button to review this collection again.</p>\n      <i class=\"reload\"></i>\n    `;\n    emptyBox.querySelector('.reload').addEventListener('click', () => {\n      this.render(this._collection);\n      this.dispatchEvent(this.reloadFromCollectionEvent);\n    });\n    this.container.appendChild(emptyBox);\n  }\n\n  renderNoCollection() {\n    this.container.innerHTML = `<p>No valid collection</p>`;\n  }\n\n  /**\n   *\n   */\n  moveBack() {\n    const lastCard = this.currentDeck[this.currentDeck.length - 1];\n    this.currentDeck = [lastCard, ...this.currentDeck.slice(0, -1)];\n    const elmt = this.container.lastElementChild;\n    this.container.prepend(elmt);\n    elmt.firstElementChild.removeAttribute('flipped');\n  }\n\n  /**\n   * @private\n   * @param {*} prop\n   * @param {*} oldValue\n   * @param {*} newValue\n   */\n  propertyChangedCallback(prop, oldValue, newValue) {\n    // cards collections are considered immutable\n    if (prop === 'collection' && oldValue !== newValue) {\n      if(Array.isArray(newValue) && newValue.length > 0) {\n        this.render([...newValue]);\n        this._collection = newValue;\n      } else {\n        this.renderNoCollection();\n        this._collection = null;\n        this.currentDeck = null;\n      }\n    }\n  }\n\n  render(cards) {\n    if (!this.currentDeck || cards.length !== this.currentDeck.length) {\n      this.container.style.paddingTop = `${cards.length * 5}px`;\n    }\n    this.container.innerHTML = cards\n      .map(\n        card => `\n          <div class=\"card-wrapper\">\n            ${cardHtml(card)}\n          </div>\n        `\n      )\n      .join('');\n    this.currentDeck = cards;\n  }\n}\n\ncustomElements.define('dc-stack', CardStackComponent);\n"]}

@justinfagnani
Copy link

Jasmine requires the describe/it syntax, which is pretty bad, IMO, in that specs are not tests and tests are not specs. Mocha at least offers a choice.

In the Polymer projects we use mainline Mocha and Chai, and just load any other needed files via script tags. It's more important that library under test and tests are modules, than the test framework for the moment.

@nweldev
Copy link
Contributor Author

nweldev commented Aug 16, 2019

About using Chai directly (answer to #729 (comment)):

This is just a workaround permitting to use chai plugins without any modification. I would be happy to do a PR for that, but I think I would only instructions to the documentation, without modifying anything, because it looks kind of dirty ... except if you think we should provide some Chai plugins by default?

And I get the following error when we add './node_modules/chai/chai.js' to the files array in karma config, so we do need the bundled-es-modules version of Chai.

/node_modules/chai/chai.js?9a923235b425351d1145c8b35681392c3ae3b3b5: Unexpected token, expected ";" (21:48)

  19 | /*!
  20 |  * Assertion Error
> 21 |  */{ pattern: 'test/utils/chai-plugins.js', type: 'module' }
     |                                                 ^
  22 | 
  23 | exports.AssertionError = require('assertion-error');
  24 | 
HeadlessChrome 76.0.3809 (Linux 0.0.0) ERROR: 'failed to load element http://localhost:9876/base/node_modules/chai/chai.js?9a923235b425351d1145c8b35681392c3ae3b3b5'
HeadlessChrome 76.0.3809 (Linux 0.0.0) ERROR: 'failed to load element http://localhost:9876/base/node_modules/chai/chai.js?9a923235b425351d1145c8b35681392c3ae3b3b5'

@nweldev
Copy link
Contributor Author

nweldev commented Aug 16, 2019

And thx for the explanations you provided @justinfagnani & @daKmoR! This will be very useful for my next talk 😃 @daKmoR, are you talking about the "should" syntax? I would love to have a discussion about these topics with you both, but maybe it would be better to do that out of Github, in order to avoid to pollute the issues.

@daKmoR
Copy link
Member

daKmoR commented Aug 16, 2019

Using karma-jasmine, I get exactly the same file in the browser, except the link to the source-map is added at the end. But with Mocha, I get:

the transformation you see is for code coverage... it has "nothing" to with mocha... I assume you would get the same transformations if you apply code coverage and you run it with jasmine

Jasmine requires the describe/it syntax, which is pretty bad, IMO

hehe I see this as another "holy" war - equal to tabs vs spaces or " vs '... let's not open this particular pandora's box here 🙈

In the Polymer projects we use mainline Mocha and Chai, and just load any other needed files via script tags.

something to test out 💪

we will probably need to change our existing plugins or at least load them differently as I assume that is why @noelmace sees the errors when not using the bundles es module version of chai...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants