Fix peerDependencies in eslint-config #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b485406 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I'm not sure what I did wrong when adding this changeset. I'm deleting this file and going to let the maintainers add a changeset properly.
felixapitzsch
approved these changes
Oct 29, 2020
|
Could someone from this project (with write access) please review and approve this PR? It is a really simple fix. However, the issue is really blocking me and my colleagues. And all other means to work around the issue are very hacky. |
|
Hrm. Looks like prettier fails on the auto generated changeset. Thats something we'll have to look into and fix, for now, could you pull and run |
daKmoR
approved these changes
Oct 29, 2020
|
formatted it 👍 thank you 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-configshould depend on@babel/eslint-plugin, not the legacyeslint-plugin-babel. This fixes install errors when using npm@7, which now automatically installs peer dependencies.Closes #1951.