Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens Module #3

Merged
merged 10 commits into from
Nov 1, 2019
Merged

Tokens Module #3

merged 10 commits into from
Nov 1, 2019

Conversation

shaunxw
Copy link
Member

@shaunxw shaunxw commented Oct 31, 2019

Version 1 impl for tokens module #4

@shaunxw shaunxw requested a review from xlc October 31, 2019 23:52
tokens/src/lib.rs Outdated Show resolved Hide resolved
tokens/src/lib.rs Outdated Show resolved Hide resolved
tokens/src/lib.rs Outdated Show resolved Hide resolved
traits/src/lib.rs Outdated Show resolved Hide resolved
@xlc
Copy link
Member

xlc commented Nov 1, 2019

For next phrase:

  • use decl_error and avoid string errors
  • make tokens module works with Currency / Balances module

@shaunxw
Copy link
Member Author

shaunxw commented Nov 1, 2019

Will open other PRs for improvements.

As the ongoing "imbalances" types development would change most function signatures, unit tests would be added in other PRs along with these change.

@shaunxw shaunxw marked this pull request as ready for review November 1, 2019 03:48
@shaunxw shaunxw merged commit ba00f23 into master Nov 1, 2019
@xlc xlc deleted the feature/tokens branch November 1, 2019 04:05
rozgo pushed a commit to SugarFunge/open-runtime-module-library that referenced this pull request May 4, 2021
imstar15 pushed a commit to imstar15/open-runtime-module-library that referenced this pull request Nov 16, 2022
…sts-uses-nextCurrencyId

Modified fn exists to use next currency id rather than storage contai…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants