Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New weight meter PR #478

Merged
merged 44 commits into from
May 17, 2021
Merged

New weight meter PR #478

merged 44 commits into from
May 17, 2021

Conversation

ermalkaleci
Copy link
Member

No description provided.

ermalkaleci and others added 30 commits March 11, 2021 19:49
@ermalkaleci
init weight_meter
e62e1ed
@ermalkaleci
update meter static var
1ee5d69
@ermalkaleci
update workspace
9250171
@ermalkaleci
fmt
8f85cf8
@ermalkaleci
clippy allow unused imports
61615e5
@ermalkaleci
default std
8b465d9
@ermalkaleci
update cargo
8e40a04
@ermalkaleci
remove std
04f659b
@ermalkaleci
revert until fix no_std issue
8edec36
@ermalkaleci
improvements
41136b8
@ermalkaleci
fmt
1485035
@ermalkaleci
update argument extract
0d6c751
@ermalkaleci
package name with orml prefix
135d43d
@ermalkaleci
update meter to be Mutex
c6040e1
@ermalkaleci
use mutex only in std
c8d7d73
@ermalkaleci
update README
b857553
@ermalkaleci
update README
d7a3af0
@ermalkaleci
update property name
c5ab5a4
@ermalkaleci
separate method injector
5dadd78
@ermalkaleci
docs
46a7969
@ermalkaleci
fmt
d46f3d4
@ermalkaleci
clippy
3116627
@brettkolodny @shaunxw
@DenisRomanovsky @bette7 @wangjj9219 @xlc @transxask @Noxime @ermalkaleci @sea212
Orml bencher (#452)
9245ede 
* Use MultiLocation as xtokens transfer dest type. (#396)

* Use MultiLocation as xtokens transfer dest type.

* Make clippy happy.

* Use xcm-handler to execute XCM locally (#401)

* Use cumulus xcm-handler to execute XCM locally.

* Add docstring for xtokens config.

* Replace XcmError::Undefined usage. (#402)

* Replace XcmError::Undefined usage.

* make clippy happy

* Bump and unify serde versions. (#403)

* xtokens and xcm-support documentations (#404)

* Add xtokens module docstring.

* Add xtokens readme.

* Add documentations for xcm-support.

* Add xtokens and xcm-support entries in main readme.

* Add unit tests for xcm-support. (#405)

* Added Minterest to the list of users. (#406)

* update step guide link

* Handle unknown assets in TransactAsset impl (#409)

* Handle unknown assets in TransactAsset impl.

* More documentations.

* Clean code.

* Renaming.

* Should try to deposit known asset first.

* Return error if no UnknownAsset impl.

* Make clippy happy.

* Fix description and repo link. (#410)

* Unknown tokens pallet (#411)

* Impl unknown tokens pallet.

* Fix workspace pallet path.

* Make clippy happy.

* Clippy, be happy.

* Unit tests.

* Remove nonces from oracle pallet. (#413)

* refactor rewards (#412)

* Bump rococo v1 dependencies (#418)

* Fix mocks.

* Replace deprecated.

* Update orml-unknown-tokens unit tests. (#421)

* add build-script-utils from Substrate (#422)

* Update README.md (#420)

* Update README.md

* Update README.md

* Bump impl-trait-for-tuples to 0.2.1 (#424)

* update Cargo.toml (#429)

* bencher init commit

* split into files

* clean deps

* add docs

* use frame_benchmarking apis

* add macro bencher_use to export stuff for bench_runner

* * generate weights file
* refactor

* improvements

* CLI Options (#446)

* Added command line options for output, headers, and templates

* Fixed options to conform to standard cli

* Added weight-gen cli

* fixed dependencies

* Replaced unwraps with expects (#449)

* Orml bencher (#451)

* add Handler (#431)

* remove disable-tokens-by-owner (#434)

* Cross-chain transfer rework (#432)

* Reserve chain trait.

* Rework cross-chain transfer.

* Remove relay chain balance convert.

* Add 'Parse' trait.

* Change transfer_multiasset fn signature.

* Add transfer dispatchable call.

* Update doc.

* Use xcm-simulator to mock network.

* Send relay chain asset to sibling unit test.

* Move location traits into orml-traits.

* Add MultiNativeAsset filter for is reserve check.

* More unit tests.

* Failing edge case unit tests.

* Handle zero amount asset case.

* Fix mocks.

* Renaming.

* Update currency adapter to work with new xtokens impl (#436)

* Xcm support implementations rework.

* Update xtokens mock.

* Use CurrencyId convert. (#437)

* Use CurrencyId convert.

* Apply review suggestions.

* Update xtokens docs. (#438)

* Update xtokens docs.

* Fix typo.

* Update imbalances impl.

* Don't deposit failure event in orml-unknown-tokens. (#440)

* Don't deposit failure event in orml-unknown-tokens.

* Patch substrate/polkadot/cumulus.

* Fix patch.

* Update README.md (#441)

Include Zeitgeist into "Projects using ORML" section

* Add PoV size in benchmarking. (#442)

* Bump cumulus ref in cargo patch. (#443)

* fix missing features (#444)

* fix missing features

* test with benchmarks

* update auction weight (#445)

* Bump dependencies. (#448)

* Replaced unwraps with expects

Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
Co-authored-by: Shaun Wang <spxwang@gmail.com>
Co-authored-by: Harald Heckmann <harald.heckmann93@web.de>
Co-authored-by: wangjj9219 <183318287@qq.com>

Co-authored-by: Shaun Wang <spxwang@gmail.com>
Co-authored-by: dzianis.ramanouski <DenisRomanovsky@users.noreply.github.com>
Co-authored-by: Bette <42193328+bette7@users.noreply.github.com>
Co-authored-by: wangjj9219 <183318287@qq.com>
Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
Co-authored-by: transxask <68648225+transxask@users.noreply.github.com>
Co-authored-by: Aaro Perämaa <aaro.peramaa@gmail.com>
Co-authored-by: Ermal Kaleci <ermalkaleci@gmail.com>
Co-authored-by: Harald Heckmann <harald.heckmann93@web.de>
@ermalkaleci
fix bencher dependencies
2c253fa
@brettkolodny @ermalkaleci
Weight meter (#459)
4d21e02 
* Added argument to BenchmarkingState
@xlc @ermalkaleci
fix
db799bc
@brettkolodny @ermalkaleci
Updated frame-support version (#461)
7dc337e
@ermalkaleci
Merge branch 'master' of github.com:open-web3-stack/open-runtime-modu…
bb2e1ad 
…le-library into new_weight_meter
@brettkolodny
clippy
b516ee1
@brettkolodny
fmt
89db2f7
This was referenced May 5, 2021
Closed
Closed
@xlc xlc requested a review from shaunxw May 6, 2021 02:41
shaunxw
shaunxw reviewed May 6, 2021
View reviewed changes
Copy link
Member

@shaunxw shaunxw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some unit tests like in frame-support to make sure all the macros expands as expected.

Prints should be replaced with log.

weight-meter/Cargo.toml Outdated Show resolved Hide resolved
xlc
xlc approved these changes May 11, 2021
View reviewed changes
weight-meter/src/lib.rs Outdated
@@ -2,6 +2,9 @@

use frame_support::weights::Weight;

// For use in mock file
extern crate self as orml_weight_meter;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting you can do this why is it needed here? how about use crate as orml_weight_meter in mock.rs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I had originally tried but for some reason I couldn't get it to work.

ermalkaleci
ermalkaleci commented May 11, 2021
View reviewed changes
weight-meter/src/lib.rs Outdated Show resolved Hide resolved
weight-meter/src/meter_std.rs Outdated Show resolved Hide resolved
weight-meter/src/meter_std.rs Outdated Show resolved Hide resolved
@xlc xlc merged commit cda5f64 into master May 17, 2021
@xlc xlc deleted the new_weight_meter branch May 17, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettkolodny brettkolodny brettkolodny left review comments

@xlc xlc xlc approved these changes

@shaunxw shaunxw shaunxw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ermalkaleci @xlc @shaunxw @brettkolodny