-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding stats to dedup #55
Comments
awesome suggestions!
|
I personally favor (3b) - code would be more consistent, kind of. Stats belong to one place, kind of - would be easier to address https://github.com/mirnylab/pairsamtools/issues/54 |
re: 3(b), yes, your understanding is right, calculate all statistics via |
In order to address open2c/distiller-nf#80 we agreed to add stats to the
dedup
.And this: https://github.com/mirnylab/pairsamtools/blob/e725dbbd037f169a5def3891783f7b2cf3922463/pairsamtools/pairsam_dedup.py#L315 looks like a proper place to add something like
out_stat.add_pair(algn2, algn1, pair_type)
Techincal Qs:
line_buffer[i]
right next to where we're writing it tooutstream
?cols_buffer[i]
(used for mark duplicates) for stats and skip parsingline_buffer[i]
?stats
-API, and instead ofout_stat.add_pair(algn2, algn1, pair_type)
, sayout_stat.add_pair(c2, p2, s2, c1, p1, s1, pair_type)
, wherealgn={'chrom':c,'pos':p,'strand':s}
?Such an API change would simplify
stats
module itself, here https://github.com/mirnylab/pairsamtools/blob/e725dbbd037f169a5def3891783f7b2cf3922463/pairsamtools/pairsam_stats.py#L78It was written the way it is right now, in order to please and simplify
parse
-code, i.e. avoid unpackingalign
dictionaries there.What do you @golobor , @nvictus guys think ?
The text was updated successfully, but these errors were encountered: