Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup stats #58

Merged
merged 3 commits into from
Dec 22, 2017
Merged

Dedup stats #58

merged 3 commits into from
Dec 22, 2017

Conversation

sergpolly
Copy link
Member

@golobor finally, I've made something to address https://github.com/mirnylab/pairsamtools/issues/55

Sorry it took so long!

This more of a conversation starter, rather than the final version.
It is working correctly on your test mock.4dedup.pairsam, producing correct stats and outputs (checked for different mismatch radii).

Haven't tested performance or larger data.
Once we finalize this thing it would be much easier to update distiller

@golobor golobor merged commit 7f890c2 into open2c:master Dec 22, 2017
@golobor
Copy link
Member

golobor commented Dec 22, 2017

apologies for the delay! This looks very good, thank you!
What else should be done in your opinion?

@sergpolly
Copy link
Member Author

Thank you! Now we should obviously fix the distiller open2c/distiller-nf#80

I'd also consider the optical dedups thing https://github.com/mirnylab/pairsamtools/issues/59
this addition, should be easy now: https://github.com/mirnylab/pairsamtools/issues/54
and maybe this, if I knew what is it: https://github.com/mirnylab/pairsamtools/issues/56

Maybe stats could be Cythonized a little bit - but I have to measure the performance at first

@sergpolly sergpolly deleted the dedup_stats branch December 22, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants