Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCF: 'NULL' events on successful N5 (npcf) request #1120

Closed
oktavlachs opened this issue Aug 4, 2021 · 7 comments
Closed

PCF: 'NULL' events on successful N5 (npcf) request #1120

oktavlachs opened this issue Aug 4, 2021 · 7 comments

Comments

@oktavlachs
Copy link

oktavlachs commented Aug 4, 2021

Hi there and thank you so much for managing this awesome project 😺

I am testing the N5 interface between P-CSCF and PCF and discovered that for a successful request towards the PCF I get weird event values in the response message.

Request type: POST /npcf-policyauthorization/v1/app-sessions

Request body:

{
 "ascReqData": {
  "afAppId": "IMS Services", 
  "dnn": "internet", 
  "medComponents": {
   "0": {
    "medCompN": 0,
    "medSubComps": {
     "0": {
      "fNum": 0,
      "fDescs": ["permit out ip from 10.46.0.3 59999 to 192.168.0.146 5060", "permit in ip from 192.168.0.146 5060 to 10.46.0.3 59999"],
      "flowUsage": "AF_SIGNALLING"
     }
    }, 
    "medType": "CONTROL",
    "codecs": ["downlink\noffer\n", "uplink\nanswer\n"],
    "fStatus": "ENABLED"
   }
  },
  "evSubsc": {
   "events": [{
     "event": "CHARGING_CORRELATION"
    }, {
     "event": "ANI_REPORT",
     "notifMethod": "ONE_TIME"
   }]
  },
  "notifUri": "/some-uri",
  "sponStatus": "SPONSOR_DISABLED",
  "supi": "imsi-001011234567895",
  "suppFeat": "2",
  "ueIpv4": "172.22.0.24"
 }
}

PCF response body (Status Code is 201):

{
 "ascReqData": {
  "afAppId": "IMS Services",
  "dnn": "internet",
  "evSubsc": {
   "events": [{
     "event": "NULL"
    }, {
     "event": "NULL",
     "notifMethod": "ONE_TIME"
    }]
  },
  "medComponents": {
   "0": {
    "codecs": ["downlink\noffer\n", "uplink\nanswer\n"],
    "fStatus": "ENABLED",
    "medCompN": 0,
    "medSubComps": {
     "0": {
      "fNum": 0,
      "fDescs": ["permit out ip from 10.46.0.3 59999 to 192.168.0.146 5060", "permit in ip from 192.168.0.146 5060 to 10.46.0.3 59999"],
      "flowUsage": "AF_SIGNALLING"
     }
    },
    "medType": "CONTROL"
   }
  },
  "notifUri": "/some-uri",
  "sponStatus": "SPONSOR_DISABLED",
  "supi": "imsi-001011234567895",
  "suppFeat": "2",
  "ueIpv4": "172.22.0.24"
 }
}

The OpenAPI specs do not offer NULL value for an 'AfEvent' type though, only the ones documented here
Do you agree that this is a bug in the PCF?

Cheers!

@acetcom
Copy link
Member

acetcom commented Aug 8, 2021

Hi @oktavlachs

It's an Open5GS bug. I've modified and updated it to the main branch on github.
Note that VoNR feature is not fully implemented. As such, further testing may not be possible.

Thank you for sharing it!
Sukchan

@oktavlachs
Copy link
Author

Fantastic, thanks for taking care of this!
Any roadmap for VoNR? Should I report more bugs while I am testing or come up with own PRs?

I am looking into this topic with @herlesupreeth

Cheers

@acetcom
Copy link
Member

acetcom commented Aug 8, 2021

@oktavlachs

Both issues and pull requests are welcome. Just choose the method you like best.

I am concentrating on what I do for a living. For the time being, it looks like no new features will be added unless requested by the sponsor.

Let me know if you have any further questions.

Thanks a lot!
Sukchan

@oktavlachs
Copy link
Author

@acetcom
You can close this issue, as it was fixed :)

Thanks!

@carloplazz
Copy link

Hi @oktavlachs
How did you configured the PCF in order to receive messages from the N5 interface?
Sorry for the dumb question :)

@oktavlachs
Copy link
Author

Hi @carloplazz
I have not worked on this recently so unfortunately I cannot recall. But I am pretty sure it worked out of the box after deploying the ng-voice IMS.
Maybe you can elaborate a bit more on what your issue is?

@carloplazz
Copy link

No problem, I've resolved that problem.
Now I'm facing your same issue of 'NULL' events on successful request using the Update PATCH method.
Also if I send a GET request to read an existing Individual Application Session Context the PCF responds me with '403 Invalid HTTP method'
GET read session error.zip.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants