Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt tutorial format to dockerized VoLTE lab #412

Merged
merged 2 commits into from
Apr 18, 2020
Merged

Adopt tutorial format to dockerized VoLTE lab #412

merged 2 commits into from
Apr 18, 2020

Conversation

miaoski
Copy link
Contributor

@miaoski miaoski commented Apr 18, 2020

Hi @acetcom ,

Not sure if I followed the right format of writing a tutorial. I saw quite a few people got stuck by VoLTE in the issue list. Hope the tutorial help a bit. Also, many thanks to @herlesupreeth 's help in the discussion of issue #337 .

Thank you!

@acetcom acetcom merged commit c00f67c into open5gs:master Apr 18, 2020
@acetcom
Copy link
Member

acetcom commented Apr 18, 2020

Hi @miaoski and @herlesupreeth

It’s really wonderful document.
Please feel free to raise whatever you think open5gs should update.

Thank you very much!

acetcom added a commit that referenced this pull request Apr 18, 2020
@acetcom
Copy link
Member

acetcom commented Apr 18, 2020

Hi @miaoski and @herlesupreeth

@herlesupreeth uses the official open5gs github instead of his hack branch in https://github.com/herlesupreeth/docker_open5gs

However, @miaoski mention @herlesupreeth's github hack branch as below:

Important notice before you start

  1. Herle Supreeth’s “noipv6” hack of Open5GS is used, because my phone isn’t able to connect to IMS via IPv6. Even if you choose “IPv4 Only” in APN configuration on the UE, Open5GS still allocates an IPv6 address to both APN internet and ims.

IMHO, open5gs can configure UE-IPv4-Only using MongoDB configuration. At this point, I have one questions. Do I need to update github master branch to support VoLTE services? Basically, I would like to support this feature without changing any source code.

Please let me know what should I do in master branch.

Thank you very much!
Sukchan

@miaoski
Copy link
Contributor Author

miaoski commented Apr 19, 2020

Hi @acetcom ,
Yes, you are right! I have verified it. Let me update the repo as well as the tutorial. You don't have to modify anything in the master branch. Thank you!

@herlesupreeth
Copy link
Contributor

Even if you choose “IPv4 Only” in APN configuration on the UE, Open5GS still allocates an IPv6 address to both APN internet and ims.

@acetcom: this is the actual behaviour happening on master branch. I have sent in a pull request to make sure that forcing IPv4 or IPv6 is properly imposed.

At this point, I have one questions. Do I need to update github master branch to support VoLTE services? Basically, I would like to support this feature without changing any source code.

Apart from the above mentioned pull request no other source code changes are required. 'hacks' branch of mine is no longer needed for VoLTE to be forced over IPv4

@acetcom
Copy link
Member

acetcom commented Apr 19, 2020

Hi @herlesupreeth and @miaoski

I’ve merged all pull request.
Thank you very much!

Sukchan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants