Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup of namespace 1 URI #2718

Merged
merged 3 commits into from
May 28, 2019
Merged

Fix setup of namespace 1 URI #2718

merged 3 commits into from
May 28, 2019

Conversation

jojastahl
Copy link
Contributor

@jojastahl jojastahl commented May 8, 2019

Fix namespace 1 initialisation problem that was introduced in commit fd08d01.

Fixes #2692

@jpfr
Copy link
Member

jpfr commented May 8, 2019

Looks good!
We should document at which point the ns1 URI is finalized in the server.
What would be required to allow changes later in the lifecycle?

@jojastahl
Copy link
Contributor Author

jojastahl commented May 8, 2019

We should document at which point the ns1 URI is finalized in the server.

This is as soon as the Namespace Array is read or written via node value read / write services, or UA_Server_addNamespace, UA_Server_getNamespaceByName or UA_Server_run_startup is called.

What would be required to allow changes later in the lifecycle?

I do not know if this should be possible. Currently writing to the namespace array via node value write service actively checks that existing namespaces are not changed. So I'm afraid, that changing a namespace URI later on is an allowed operation as this changes the identification of all nodes referring to its index.

@jojastahl jojastahl changed the title WIP: Fix setup of namespace 1 URI Fix setup of namespace 1 URI May 10, 2019
@Pro
Copy link
Member

Pro commented May 27, 2019

I added some more comments. This can be merged as soon as CI is green

@Pro Pro self-assigned this May 27, 2019
@Pro Pro merged commit 3101cc2 into open62541:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server configuration and initialisation flaws
3 participants