Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: symmetric createMonitoredItemDataChange, deleteMonitoredItem #238

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

lukasberbuer
Copy link
Member

Symmetric implementation (same definition for Server and Client) for:

  • services::createMonitoredItemDataChange
  • services::deleteMonitoredItem

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 85.12%. Comparing base (dc7c732) to head (846edf4).

Files Patch % Lines
src/services/MonitoredItem.cpp 87.50% 0 Missing and 4 partials ⚠️
include/open62541pp/MonitoredItem.h 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   85.14%   85.12%   -0.03%     
==========================================
  Files          80       80              
  Lines        4356     4355       -1     
  Branches     1746     1760      +14     
==========================================
- Hits         3709     3707       -2     
+ Misses        204      202       -2     
- Partials      443      446       +3     
Flag Coverage Δ
Linux 85.12% <88.88%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasberbuer lukasberbuer merged commit 6f33275 into master Mar 19, 2024
71 checks passed
@lukasberbuer lukasberbuer deleted the feat/symmetric-monitoreditem-function branch March 19, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant