Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save files don't work unless ~/luppp already exists #163

Closed
harryhaaren opened this issue Jan 8, 2017 · 8 comments
Closed

Save files don't work unless ~/luppp already exists #163

harryhaaren opened this issue Jan 8, 2017 · 8 comments
Assignees
Milestone

Comments

@harryhaaren
Copy link
Member

If the ~/luppp directory does not exist, Luppp doesn't save a file. This needs to be fixed asap, should be a small change to ensure that the luppp/ folder exists.

@harryhaaren harryhaaren added this to the Release 1.2 milestone Jan 8, 2017
@harryhaaren harryhaaren self-assigned this Jan 8, 2017
@trebmuh
Copy link
Contributor

trebmuh commented Jan 8, 2017

Hi @harryhaaren , I think this bug as been reported by one of my (LibraZiK) user. Then, I can propose you to let me know when a fix is found, and I'll be updating the LibraZiK luppp package to check if everything is correct.

@harryhaaren
Copy link
Member Author

@trebmuh - fixed now, I'll be doing a 1.1.1 release to solve this, as it is a critical bug particularly affecting new users of Luppp (as the session dir wouldn't have existed yet).

@trebmuh
Copy link
Contributor

trebmuh commented Jan 8, 2017

Making a 1.1.1 is a good idea.
I've been re-doing a package for LibraZiK for 1.1 + this patch. I think Nico will let you know about is soon.

@sub26nico
Copy link
Contributor

Hi, I have tested this new package in LibraZiK, I tried first to save an an empty project and anything
happened, so I recorded a loop then save the project and the ~/luppp had been created with my project.
Once the ~/luppp was created, it is possible to save an empty project.

@harryhaaren
Copy link
Member Author

Hi @sub26nico, I can't reproduce the issue here - saving empty sessions, as well as normal sessions seems fine. Would you please re test?

# Please make sure you don't have any Luppp sessions you want to keep here!!
#rm -r luppp
./luppp
# click menu -> Save -> "dirTest"
ls ~/luppp/
# shows the project "dirTest.luppp" directory save file for me

Please also confirm you're testing with the fix version :D
[Luppp] main:63: Git: e8b15b3 fix #163; save file dir parent dir created

Thanks, -Harry

@sub26nico
Copy link
Contributor

It's OK, after #rm -r luppp (the folder was deleted in my HOME), I've opened Luppp,
and save the empty project, naming it 'dirTest' and the luppp folder is created in my HOME.
I don't know what happened the first time. And yes, I'm using the version with the patch,
with the new package done by @trebmuh.

@harryhaaren
Copy link
Member Author

Thanks for verifying the fix, and a shout out to Trebmuh for packaging up quickly for testing :D

@trebmuh
Copy link
Contributor

trebmuh commented Jan 9, 2017

and thanks to you as well to have been that responsive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants