Feat: Instant Search feature in search fragment #1524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @robustTechie ! This feature is addressed in this PR #1338 . Please review! |
|
Yeah it has a conflict. Anyway I'll close that PR. |
|
Ok |
Grandolf49
requested changes
Jun 23, 2020
| String query = charSequence.toString(); | ||
| if (!query.equals("")) { | ||
| showInstantSearchedProgressBar(true); | ||
| searchPresenter.searchInstantResources(query, resources, false); |
There was a problem hiding this comment.
After discussion with @therajanmaurya , he mentioned that we should not perform API calls in the onTextChanged method since it burdens the server with unnecessary API Calls.
You might want to check debounce to achieve this.
|
We are closing this PR as it causes a branch conflict since the Java file has now been migrated to kotlin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1335
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.