Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion: Create new Client #1533

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Conversation

iamsh4shank
Copy link
Member

@iamsh4shank iamsh4shank commented Aug 11, 2020

Fixes #1534
Converted the following classes which were previously in Java, to Kotlin -

  1. CreateNewClientFragment
  2. CreateNewClientMvpView
  3. CreateNewClientPresenter

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@iamsh4shank iamsh4shank changed the base branch from master to kotlin-conversion February 10, 2021 16:46
Copy link
Collaborator

@Grandolf49 Grandolf49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Grandolf49 Grandolf49 merged commit 55e6c1d into openMF:kotlin-conversion Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java to Kotlin conversion: Create new Client
3 participants