Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructured: xml files for regex activity*.xml and dialog*.xml #1874

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

avivijay19
Copy link
Collaborator

Fixes #1873

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@avivijay19
Copy link
Collaborator Author

Review and merge the code of this issue Bintray then merge above code.

@avivijay19
Copy link
Collaborator Author

@danishjamal104 @iamsh4shank ,
please review the PR,

PR Solves

  • The deprecated dependency of the XMLs of regex activity*.xml and dialog*.xml

Copy link
Collaborator

@danishjamal104 danishjamal104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avinash14022002 does this PR include any functional change?

@avivijay19
Copy link
Collaborator Author

@avinash14022002 does this PR include any functional change?

No,
The PR only have UI dependency update and rearrangement of XMLs.

@avivijay19
Copy link
Collaborator Author

@avinash14022002 does this PR include any functional change?

No, The PR only have UI dependency update and rearrangement of XMLs.

@danishjamal104
No UI break detected

Copy link
Collaborator

@danishjamal104 danishjamal104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danishjamal104
Copy link
Collaborator

@iamsh4shank merge this. Thanks :)

@avivijay19 avivijay19 merged commit 2361cf2 into openMF:master Aug 9, 2022
@avivijay19 avivijay19 deleted the ui-warning-dialog-activity branch August 9, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings on xmls files for activity regex and dialog
2 participants