Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBFlow dependency refactor #1879

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Conversation

avivijay19
Copy link
Collaborator

Fixes #1878

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@@ -156,12 +156,12 @@ dependencies {

//DBFlow dependencies
implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
annotationProcessor "com.github.Raizlabs.DBFlow.dbflow:dbflow-processor:3.1.1"
annotationProcessor "com.github.Raizlabs.DBFlow:dbflow-processor:3.1.1"
annotationProcessor "com.github.raizlabs.dbflow.dbflow:dbflow-processor:3.1.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason of renaming this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danishjamal104
Link for the reference

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

implementation "com.github.Raizlabs.DBFlow.dbflow:dbflow:$rootProject.raizLabsDBFlow"
kapt "com.github.Raizlabs.DBFlow:dbflow-processor:3.1.1"
implementation "com.github.raizlabs.dbflow.dbflow:dbflow:$rootProject.raizLabsDBFlow"
kapt "com.github.raizlabs.dbflow:dbflow-processor:3.1.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you provide a reference for the dbFlow dependency name update?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked well I had the same issue.

Copy link
Collaborator

@danishjamal104 danishjamal104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danishjamal104
Copy link
Collaborator

@iamsh4shank merge this. Thanks :)

@iamsh4shank iamsh4shank merged commit 2538a9c into openMF:master Aug 1, 2022
@avivijay19 avivijay19 deleted the issue-1878 branch August 1, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails due to a dependency on DBFlow
4 participants