-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBFlow dependency refactor #1879
Conversation
@@ -156,12 +156,12 @@ dependencies { | |||
|
|||
//DBFlow dependencies | |||
implementation 'androidx.constraintlayout:constraintlayout:1.1.3' | |||
annotationProcessor "com.github.Raizlabs.DBFlow.dbflow:dbflow-processor:3.1.1" | |||
annotationProcessor "com.github.Raizlabs.DBFlow:dbflow-processor:3.1.1" | |||
annotationProcessor "com.github.raizlabs.dbflow.dbflow:dbflow-processor:3.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the reason of renaming this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danishjamal104
Link for the reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool
implementation "com.github.Raizlabs.DBFlow.dbflow:dbflow:$rootProject.raizLabsDBFlow" | ||
kapt "com.github.Raizlabs.DBFlow:dbflow-processor:3.1.1" | ||
implementation "com.github.raizlabs.dbflow.dbflow:dbflow:$rootProject.raizLabsDBFlow" | ||
kapt "com.github.raizlabs.dbflow:dbflow-processor:3.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you provide a reference for the dbFlow dependency name update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked well I had the same issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@iamsh4shank merge this. Thanks :) |
Fixes #1878
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.