Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade project gradle version and dependency bumps #1881

Merged
merged 2 commits into from
Aug 6, 2022

Conversation

avivijay19
Copy link
Collaborator

Fixes #1862 #1813

Please Add Screenshots If there are any UI changes.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Copy link
Collaborator

@danishjamal104 danishjamal104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avinash14022002 Task :mifosng-android:compileDebugKotlin is failing in gradle build. Please check the reason and resolve it.

@avivijay19
Copy link
Collaborator Author

@avinash14022002 Task :mifosng-android:compileDebugKotlin is failing in gradle build. Please check the reason and resolve it.

yes,
it will fail due to requireContext() which is not updated

once this PR is merged I will update the codebase

the main reason behind creating the PR is to keep Gradle and dependency issues separate from codebase changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade project gradle version and dependency bumps
3 participants