Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reskin: Moratorium Fields are not properly aligned. #2022

Closed
santoshconflux opened this issue Mar 6, 2017 · 13 comments
Closed

Reskin: Moratorium Fields are not properly aligned. #2022

santoshconflux opened this issue Mar 6, 2017 · 13 comments
Labels
design gsoc p1_MifosRelease reskin status/STALE Volunteers
Projects
GSOC Re-skin Release

Comments

@santoshconflux
Copy link
Collaborator

In screenshot , check moratorium on interest:

reskin
@gastonche
Copy link

@santoshmath Please i would like to work on this issue. on which page is that screen shot from?

@santoshconflux
Copy link
Collaborator Author

@gastonche, it's "Loan Application page" for client/group

@skprabhanjan
Copy link

@santoshmath , I have fixed this issue , if you could please tell if the interface is fine , I would go ahead and send a PR for this.
I have attached a Screenshot of the fix here .
Thanks:)

screen shot 2017-03-06 at 9 44 26 pm

@skprabhanjan
Copy link

@santoshmath Sorry, I have updated the UI. Please review this Screenshot.
Thanks:)

screen shot 2017-03-06 at 9 46 59 pm

@santoshconflux
Copy link
Collaborator Author

@skprabhanjan , It's good if Moratorium is left aligned.

@gastonche
Copy link

Then i'll go ahead and submit my pull request, i fixed the issue and have the moratorium left aligned

@santoshconflux
Copy link
Collaborator Author

@gastonche , sure

This was referenced Mar 7, 2017
Closed
Closed
@R7467
Copy link

R7467 commented Mar 13, 2017

Can you tell me if this issue is fixed or not. The Moratorium fields do not appear to be aligned.
screen shot 2017-03-13 at 9 56 14 pm

@skprabhanjan
Copy link

@santoshmath , Is this still open.? If yes, I will send a PR again
Thanks:)

@santoshconflux
Copy link
Collaborator Author

@skprabhanjan , it's still open.

@skprabhanjan
Copy link

@santoshmath, okay I will fix this and send a PR soon :)

@santoshconflux santoshconflux moved this from TODO to In Progress in GSOC Re-skin Release Apr 28, 2017
@mbj36 mbj36 moved this from In Progress to TODO in GSOC Re-skin Release Jun 5, 2017
@mbj36 mbj36 removed this from TODO in GSOC Re-skin Release Jun 7, 2017
gkrishnan724 added a commit to gkrishnan724/community-app that referenced this issue Jul 8, 2017
@gkrishnan724
Reskin: Fix openMF#2022 - Moratarium fields alignment
2dc8746
mbj36 added a commit that referenced this issue Jul 8, 2017
@mbj36
Merge pull request #2362 from gkrishnan724/moratarium
f153199 
Reskin: Fix #2022 - Moratarium fields alignment
@mbj36
Copy link
Member

mbj36 commented Jul 8, 2017

@santoshmath close it

mbj36 pushed a commit to mbj36/community-app that referenced this issue Jul 10, 2017
@gkrishnan724 @mbj36
Reskin: Fix openMF#2022 - Moratarium fields alignment
986d40c
mbj36 pushed a commit to mbj36/community-app that referenced this issue Jul 10, 2017
@gkrishnan724 @mbj36
Reskin: Fix openMF#2022 - Moratarium fields alignment
1b4774a
@santoshconflux
Copy link
Collaborator Author

Tested it on new_reskin branch. This issue is resolved.

@santoshconflux santoshconflux moved this from TODO to Done in GSOC Re-skin Release Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design gsoc p1_MifosRelease reskin status/STALE Volunteers
Projects
GSOC Re-skin Release
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mbj36 @gastonche @skprabhanjan @R7467 @santoshconflux