Dockerize #3117
Merged
Dockerize #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that travis didn't get to communicate with github https://travis-ci.com/openMF/community-app/builds/121977161 |
|
Nothing, I asked on his PR if he had time to address your comments and he said that I could go ahead So, it's just the same with those corrections |
|
OK, got it. Merging this, sorry for the delay.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DockerfileRelated issues and discussion
#3106
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
[*] Validate the JS and HTML files with
grunt validateto detect errors and potential problems in JavaScript code.[*] Run the tests by opening
test/SpecRunner.htmlin the browser to make sure you didn't break anything.[*] If you have multiple commits please combine them into one commit by squashing them.
[*] Read and understood the contribution guidelines at
community-app/Contributing.md.